We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short term goal would be to support configuration of the path (as per other configuration through environment variables).
This function would need to be modified:
chroxy/lib/chroxy/chrome_server.ex
Lines 347 to 354 in a1997bd
From early testing, Chromium was fully compatible.
The text was updated successfully, but these errors were encountered:
FWIW, I'm able to set a different browser path with:
config :chroxy, Chroxy.ChromeServer, chrome_path: System.get_env("CHROXY_CHROME_PATH")
in my own app's config.exs when using Chroxy as a library.
Is the implementation of this feature just adding the above line to Chroxy's config.exs?
config.exs
Sorry, something went wrong.
Looks like I have implemented this and forgot:
Lines 132 to 137 in a1997bd
I would suggest we document this in the README or we add that ENV VAR as something baked in that will take the first precedence.
Documentation should be fine.
No branches or pull requests
Short term goal would be to support configuration of the path (as per other configuration through environment variables).
This function would need to be modified:
chroxy/lib/chroxy/chrome_server.ex
Lines 347 to 354 in a1997bd
From early testing, Chromium was fully compatible.
The text was updated successfully, but these errors were encountered: