Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting a line in completion pop-up doesn't import elements anymore #10781

Closed
mlemesle opened this issue May 17, 2024 · 1 comment
Closed
Labels
C-bug Category: This is a bug

Comments

@mlemesle
Copy link
Contributor

Summary

Hello !

I just realized that when I select an item in the completion pop-up, the element isn't imported after insertion.
I'm almost sure it worked that way and it doesn't now since a few days ago. I know have to write the imports myself or rely on LSP code actions each time, which can be tedious.

I didn't change my configuration file and I do build Helix from master.

Here is an Asciicinema recording with a dead simple example.
asciicast

Reproduction Steps

  1. Open a file
  2. Write some code that needs import
  3. Select the desired line with (use xxx) at the end and press Enter

The element isn't imported

Helix log

No related logs

Platform

Linux

Terminal Emulator

kitty 0.34.1 created by Kovid Goyal

Installation Method

Built from source

Helix Version

helix 24.3 (00e9e5e)

@mlemesle mlemesle added the C-bug Category: This is a bug label May 17, 2024
@kirawi
Copy link
Member

kirawi commented May 18, 2024

I think this can be closed in favor of #10787 which gives a range of commits causing the potential regression

@kirawi kirawi closed this as completed May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

No branches or pull requests

2 participants