Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github/workflows: go vet fails on the test bot with Go 1.18 #2994

Closed
1 of 11 tasks
hajimehoshi opened this issue May 18, 2024 · 0 comments
Closed
1 of 11 tasks

.github/workflows: go vet fails on the test bot with Go 1.18 #2994

hajimehoshi opened this issue May 18, 2024 · 0 comments
Labels
bug os:linux test
Milestone
v2.7.4

Comments

@hajimehoshi
Copy link
Owner

Ebitengine Version

2.7 (5cf46f0)

Operating System

  • Windows
  • macOS
  • Linux
  • FreeBSD
  • OpenBSD
  • Android
  • iOS
  • Nintendo Switch
  • PlayStation 5
  • Xbox
  • Web Browsers

Go Version (go version)

Go 1.18

What steps will reproduce the problem?

Run go vet on the GitHub Actions

What is the expected result?

The go-vet passes

What happens instead?

The go-vet fails:

# golang.org/x/tools/go/types/objectpath
Error: ../../../go/pkg/mod/golang.org/x/tools@v0.21.0/go/types/objectpath/objectpath.go:397:10: meth.Origin undefined (type *types.Func has no field or method Origin)
note: module requires Go 1.19
Error: Process completed with exit code 2.

Anything else you feel useful to add?

Some tools are no longer available with Go 1.18. Just disable go-vet for Go 1.18.
@hajimehoshi hajimehoshi added this to the v2.7.4 milestone May 18, 2024
hajimehoshi added a commit that referenced this issue May 18, 2024
@hajimehoshi
.github/workflows: stop go-vet for Go 1.18
9c1ab8e 
Some tools are not available for Go 1.18 due to a new method:
(*go/types.Func).Origin.

Closes #2994
hajimehoshi added a commit that referenced this issue May 18, 2024
@hajimehoshi
all: drop Go 1.18 support
30d6e11 
Unfortunately, golang.org/x/tools requires Go 1.19 or newer.

Updates #2994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug os:linux test
Projects
None yet
Milestone
v2.7.4
Development

No branches or pull requests
1 participant
@hajimehoshi