Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not Receiving Signal when Position Changed #2

Open
ashteligenz opened this issue Oct 11, 2019 · 8 comments
Open

Not Receiving Signal when Position Changed #2

ashteligenz opened this issue Oct 11, 2019 · 8 comments

Comments

@ashteligenz
Copy link

@AlexStefan I am not able to receive signals when bottom sheet at Top, Middle and Bottom positions. There is no event raised when we move bottomsheet at different positions.

@AlexStefan
Copy link
Contributor

This is indeed not implemented. Would be a solution to have a property that allows you to check the state of the BottomSheet? Or you actually need to subscribe to an event?

@ashteligenz
Copy link
Author

@AlexStefan I want a property to check the state of bottom sheet.

@bardigolriz
Copy link

@AlexStefan I consider this to be an essential requirement. Surprised, considering how impressive this control is generally speaking, for this to not be available to depend on.

@AlexStefan
Copy link
Contributor

@bardigolriz I will look into it these days and add a property to be able to check on it. :D

@bardigolriz
Copy link

Awesome, thanks @AlexStefan!

AlexStefan added a commit that referenced this issue Feb 3, 2020
@AlexStefan
Copy link
Contributor

Just uploaded a beta version on nuget: https://www.nuget.org/packages/XBottomSheet/1.0.4-beta. Give it a try and tell me if there is something missing. The nuget will go in stable after we'll do the android part as well. Currently the property is only available for iOS version.

@bardigolriz
Copy link

Not had a chance to test this today, but I will this week!

@bardigolriz
Copy link

bardigolriz commented Feb 6, 2020

Tested, looks good 👍

Would be great if there were events triggered when its CurrentState is 1) about to change as well as 2) has just changed (more important). On my other app, ruff, I currently use https://github.com/umano/AndroidSlidingUpPanel that has a PanelStateChanged event, meaning I can only make changes to the UI in response to panel interaction after the panel has changed state (rather than anticipate before and make intelligent adjustments as soon as it becomes apparent that the panel is in the process of change — this short time between it changing and changed may seem insignificant but it's precisely the level of control/attentiveness that help lead to a highly polished UX). Hope this makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants