-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how bots are shown on ListUsers #41644
Merged
strideynet
merged 6 commits into
master
from
strideynet/improve-how-bots-are-shown-list-users
May 17, 2024
Merged
Improve how bots are shown on ListUsers #41644
strideynet
merged 6 commits into
master
from
strideynet/improve-how-bots-are-shown-list-users
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanclark
approved these changes
May 16, 2024
Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
…thub.com:gravitational/teleport into strideynet/improve-how-bots-are-shown-list-users t push# Please enter a commit message to explain why this merge is necessary,
Tener
approved these changes
May 17, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rudream
May 17, 2024 09:54
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
May 17, 2024
* Improve how Bots are shown in ListUsers * Run prettier * Add test to backend * Update web/packages/teleport/src/services/user/makeUser.ts Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix test --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
strideynet
added a commit
that referenced
this pull request
May 17, 2024
* Improve how Bots are shown in ListUsers * Run prettier * Add test to backend * Update web/packages/teleport/src/services/user/makeUser.ts Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix test --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
This was referenced May 17, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Improve how bots are shown on ListUsers (#41644) * Improve how Bots are shown in ListUsers * Run prettier * Add test to backend * Update web/packages/teleport/src/services/user/makeUser.ts Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix test --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix lint --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 20, 2024
* Improve how bots are shown on ListUsers (#41644) * Improve how Bots are shown in ListUsers * Run prettier * Add test to backend * Update web/packages/teleport/src/services/user/makeUser.ts Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix test --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix lint and test --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
justinas
pushed a commit
that referenced
this pull request
May 20, 2024
* Improve how Bots are shown in ListUsers * Run prettier * Add test to backend * Update web/packages/teleport/src/services/user/makeUser.ts Co-authored-by: Ryan Clark <ryan.clark@goteleport.com> * Fix test --------- Co-authored-by: Ryan Clark <ryan.clark@goteleport.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41595
Changed to hide the options button as we do for SSO users, and changed the auth type column to display "Bot"
changelog: Simplified how Bots are shown on the Users list page.