Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ElementHandle APIs to async #1296

Open
3 of 5 tasks
Tracked by #428
ankur22 opened this issue May 2, 2024 · 0 comments
Open
3 of 5 tasks
Tracked by #428

Migrate ElementHandle APIs to async #1296

ankur22 opened this issue May 2, 2024 · 0 comments
Assignees
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes

Comments

@ankur22
Copy link
Collaborator

ankur22 commented May 2, 2024

Tasks

  1. mapping refactor stability
    inancgumus
  2. async breaking mapping
    inancgumus
  3. Area: browser
    inancgumus

What

Migrate the following APIs according to the How section in #428:

Class Method Current k6 Return PW return
ElementHandle $ ElementHandle|null Promise<ElementHandle<SVGElement|HTMLElement>|null>
ElementHandle $$ ElementHandle[] Promise<ElementHandle<SVGElement|HTMLElement>[]>
ElementHandle boundingBox Rect Promise<null|{x:number;y:number;width:number;height:number;}>
ElementHandle check void Promise
ElementHandle contentFrame Frame Promise<null|Frame>
ElementHandle dblclick void Promise
ElementHandle dispatchEvent void Promise
ElementHandle fill void Promise
ElementHandle focus void Promise
ElementHandle getAttribute string|null Promise<null|string>
ElementHandle hover void Promise
ElementHandle innerHTML string Promise
ElementHandle innerText string Promise
ElementHandle inputValue string Promise
ElementHandle isChecked boolean Promise
ElementHandle isDisabled boolean Promise
ElementHandle isEditable boolean Promise
ElementHandle isEnabled boolean Promise
ElementHandle isHidden boolean Promise
ElementHandle isVisible boolean Promise
ElementHandle ownerFrame Frame Promise<null|Frame>
ElementHandle press void Promise
ElementHandle screenshot ArrayBuffer Promise
ElementHandle scrollIntoViewIfNeeded void Promise
ElementHandle selectOption string[] Promise<Array>
ElementHandle selectText void Promise
ElementHandle setInputFiles void Promise
ElementHandle textContent string Promise<null|string>
ElementHandle type void Promise
ElementHandle uncheck void Promise
ElementHandle waitForElementState void Promise
ElementHandle waitForSelector ElementHandle Promise<null|ElementHandle<SVGElement|HTMLElement>>

For details on the Why and How, check the overarching issue in #428.

@ankur22 ankur22 mentioned this issue May 2, 2024
17 tasks
@ankur22 ankur22 added the async supports async (promises) label May 2, 2024
@inancgumus inancgumus added the breaking PRs that need to be mentioned in the breaking changes section of the release notes label May 6, 2024
@inancgumus inancgumus self-assigned this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
async supports async (promises) breaking PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Development

No branches or pull requests

2 participants