Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Goja entirely out of the business logic #1064

Open
2 of 15 tasks
Tracked by #1138
inancgumus opened this issue Oct 12, 2023 · 0 comments
Open
2 of 15 tasks
Tracked by #1138

Move Goja entirely out of the business logic #1064

inancgumus opened this issue Oct 12, 2023 · 0 comments
Assignees
Labels
epic productivity Issues and PRs that improve our productivity refactor stability runtime stability improvements

Comments

@inancgumus
Copy link
Member

inancgumus commented Oct 12, 2023

What?

Move Goja entirely out of the business logic.

Why?

  • Prevent Goja data races.
  • Better type-safety using native Go constructs.
  • Developer productivity increase.
  • Separation of concerns.
  • Moving Goja handling to the mapping layer will make the code easy to reason about, reduce the business logic's Goja dependency, and simplify the business logic code and tests.
  • Having Goja in the business logic requires constant encoding and decoding.

Tasks

Related PR(s)/Issue(s)

#271

@inancgumus inancgumus added refactor productivity Issues and PRs that improve our productivity labels Oct 12, 2023
@inancgumus inancgumus changed the title Move option parsing to the mapping layer Move option parsing into the mapping layer Oct 12, 2023
@inancgumus inancgumus changed the title Move option parsing into the mapping layer Move Goja entirely out of the business logic Jan 26, 2024
@ankur22 ankur22 pinned this issue Feb 7, 2024
@inancgumus inancgumus added the epic label Feb 8, 2024
@inancgumus inancgumus added the stability runtime stability improvements label Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic productivity Issues and PRs that improve our productivity refactor stability runtime stability improvements
Projects
None yet
Development

No branches or pull requests

2 participants