Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of custom serialization when reporting task validation problems via the Problems API #29188

Open
donat opened this issue May 16, 2024 · 1 comment · May be fixed by #29189
Open

Get rid of custom serialization when reporting task validation problems via the Problems API #29188

donat opened this issue May 16, 2024 · 1 comment · May be fixed by #29189
Assignees
@donat
Labels
a:chore Minor issue without significant impact in:problems problems api
Milestone
8.9 RC1

Comments

@donat
Copy link
Member

donat commented May 16, 2024

We use ValidationProblemSerialization to transfer problems from the type validation worker to the daemon via a json file. Since now we have worker support in the problems API, it should be possible to get rid of the custom serialization code.
@donat donat added a:chore Minor issue without significant impact in:problems problems api labels May 16, 2024
@donat donat self-assigned this May 16, 2024
@donat donat added this to the 8.9 RC1 milestone May 16, 2024
@donat
Copy link
Member Author

donat commented May 16, 2024

I did a quick check if this is feasible and it seems I was able to inject the problems service to to the validation worker process. It's not a big surprise, as we already use the worker integration when emitting Java compiler diagnostics.

This was referenced May 16, 2024
Merged
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donat donat

Labels
a:chore Minor issue without significant impact in:problems problems api
Projects
None yet
Milestone
8.9 RC1
Development

Successfully merging a pull request may close this issue.

Don't use custom serialization when reporting type validation problems gradle/gradle
1 participant
@donat