Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug GitHub Actions issue #1276

Closed
joshlf opened this issue May 16, 2024 · 2 comments
Closed

Debug GitHub Actions issue #1276

joshlf opened this issue May 16, 2024 · 2 comments
Labels
bug Something isn't working experience-medium This issue is of medium difficulty, and requires some experience help wanted Extra attention is needed

Comments

@joshlf
Copy link
Member

joshlf commented May 16, 2024

I've been working on #1275, and haven't been able to get the added script in actions/zerocopy_toolchain_version/action.yml to produce output usable by workflows/ci.yml. In particular, ${{ steps.toolchain.outputs.toolchain }} always interpolates to an empty string.

I'd love it if someone with more GitHub Actions experience could take a look and see if they can figure out what's going wrong!

@joshlf joshlf added the help wanted Extra attention is needed label May 16, 2024
@joshlf joshlf added the experience-medium This issue is of medium difficulty, and requires some experience label May 29, 2024
@sl4m
Copy link
Contributor

sl4m commented Jun 3, 2024

Edit: Happy to take over your branch as well and create a new PR.

It looks like adding the following here seems to do the trick:

outputs:
  toolchain:
    description: 'Resolved toolchain version'
    value: ${{ steps.resolve.outputs.toolchain }}

I followed the example from the doc.

Test run on my fork.

Note: I didn't see this as a GitHub issue, so wanted to flag the target clean up errors in this test run.

Target clean up errors

Originally, I thought I introduced these with the code change, but the errors appear in the official test runs as well. Example. It appears to be an issue with the action Swatinem/rust-cache, but haven't look into it further.

@joshlf
Copy link
Member Author

joshlf commented Jun 5, 2024

Amazing, thank you! I've also opened #1389 based on your observation about the target dir errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working experience-medium This issue is of medium difficulty, and requires some experience help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants