{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":15773229,"defaultBranch":"main","name":"skia","ownerLogin":"google","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-01-09T17:09:57.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1342004?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715656955.0","currentOid":""},"activityList":{"items":[{"before":"337c3c4d1f1b4a1d9ea906d1e4c45c995c859e00","after":"6ffe89f9b4cc8c1dae9c4a916f16f9c463e3fa6d","ref":"refs/heads/main","pushedAt":"2024-06-01T00:27:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll vulkan-deps from 0da3accd42f7 to 975bd14542a4 (1 revision)\n\nhttps://chromium.googlesource.com/vulkan-deps.git/+log/0da3accd42f7..975bd14542a4\n\nAlso rolling transitive DEPS:\n https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/142bf7de83b550b549b4049eb1f3dcb2ff007ec1..148c97f6876e427efd76d2328122c3075eab4b8f\n\nIf this roll has caused a breakage, revert this CL and stop the roller\nusing the controls here:\nhttps://autoroll.skia.org/r/vulkan-deps-skia-autoroll\nPlease CC bwils@google.com,skiabot@google.com on the revert to ensure that a human\nis aware of the problem.\n\nTo file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry\n\nTo report a problem with the AutoRoller itself, please file a bug:\nhttps://issues.skia.org/issues/new?component=1389291&template=1850622\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md\n\nCq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE\nBug: None\nTbr: bwils@google.com\nChange-Id: I8691c3b5f7ab5687b9454d01f1be850047bb3523\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860716\nCommit-Queue: skia-autoroll \nBot-Commit: skia-autoroll ","shortMessageHtmlLink":"Roll vulkan-deps from 0da3accd42f7 to 975bd14542a4 (1 revision)"}},{"before":"5acad790c9572b44362f0559dc14fe98986ad10b","after":"337c3c4d1f1b4a1d9ea906d1e4c45c995c859e00","ref":"refs/heads/main","pushedAt":"2024-05-31T20:37:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Remove `// HASH=xxxxxx` from examples.\n\nThis is no longer referenced anywhere.\n\nChange-Id: Ia6d9930d82ea125b2522b9172f72651887bacea1\nBug: 343939871\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859130\nCommit-Queue: John Stiles \nReviewed-by: Kaylee Lubick \nCommit-Queue: Kaylee Lubick \nAuto-Submit: John Stiles ","shortMessageHtmlLink":"Remove // HASH=xxxxxx from examples."}},{"before":"f78e13cd0c92bf54f78ee7d1f6ba6b0318347138","after":"5acad790c9572b44362f0559dc14fe98986ad10b","ref":"refs/heads/main","pushedAt":"2024-05-31T20:12:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Run a graphite tryjob when src/shaders changes\n\nChange-Id: Ia4fb8dc4a320cf45b3701edf4231979cfcbe703f\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860617\nReviewed-by: Kaylee Lubick \nReviewed-by: Michael Ludwig ","shortMessageHtmlLink":"Run a graphite tryjob when src/shaders changes"}},{"before":"7193eec6a492f61728cdf17cfabea35a3026ac20","after":"f78e13cd0c92bf54f78ee7d1f6ba6b0318347138","ref":"refs/heads/main","pushedAt":"2024-05-31T19:47:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Remove outdated example\n\nThe ones in example/external_client are based on the modular build and\nare a better example.\n\nBug: b/343229140\nChange-Id: I085e0e75820567ed63436572795ea8ac2d9720ae\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859128\nCommit-Queue: Nathan Sanchez \nReviewed-by: Nathan Sanchez \nCommit-Queue: Kaylee Lubick \nAuto-Submit: Kaylee Lubick ","shortMessageHtmlLink":"Remove outdated example"}},{"before":"07793a7c37b867d116cb053f06c6b8e459219688","after":"7193eec6a492f61728cdf17cfabea35a3026ac20","ref":"refs/heads/main","pushedAt":"2024-05-31T19:21:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[graphite] Use explicit key for analytic rect blur table\n\nBug: b/338032253\nChange-Id: I5393c294a8fd7e1c290aae78c2b5ff49bdaec4a6\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860157\nReviewed-by: Robert Phillips \nCommit-Queue: Michael Ludwig ","shortMessageHtmlLink":"[graphite] Use explicit key for analytic rect blur table"}},{"before":"f1f13534b0c2d41ca4b145c19ae108c8faf283dd","after":"07793a7c37b867d116cb053f06c6b8e459219688","ref":"refs/heads/main","pushedAt":"2024-05-31T18:55:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[graphite] Support explicit UniqueKeys in ProxyCache\n\nBug: b/338032253\nChange-Id: I974a269c62349291c0de80ae5111b1cb80d1512c\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860156\nReviewed-by: Robert Phillips \nCommit-Queue: Michael Ludwig \nReviewed-by: Greg Daniel ","shortMessageHtmlLink":"[graphite] Support explicit UniqueKeys in ProxyCache"}},{"before":"208469d270b72009abc7f63aebe0c278ae9d5207","after":"f1f13534b0c2d41ca4b145c19ae108c8faf283dd","ref":"refs/heads/main","pushedAt":"2024-05-31T18:29:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[graphite] Add matrix convolution ImageFilter to Precompilation system\n\nBug: b/259548724\nChange-Id: Ib1ef773836e5ab320ddfe3b1f5adab3753fabb49\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859396\nCommit-Queue: Robert Phillips \nReviewed-by: Jim Van Verth ","shortMessageHtmlLink":"[graphite] Add matrix convolution ImageFilter to Precompilation system"}},{"before":"ce975ddfd9fb95eabcc53ae456cefd436f96e9ef","after":"208469d270b72009abc7f63aebe0c278ae9d5207","ref":"refs/heads/main","pushedAt":"2024-05-31T17:11:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[Fontations-backend] Hinting mode switching compat for comparison test\n\nDue to the way the filtering Canvas OveridePaintFilterCanvas works, when\nswitching the hinting mode in the debug UI, the comparison would no\nlonger work. Workaround these limitations by using peekPixels to get\naccess to the Canvas' pixels instead of readPixels and later writing\nback to the same pixmap. This enables using the filtering canvas and\nswitching the font hinting mode in the debug UI without losing the\ncomparison functionality. Thanks to Ben for the suggestions.\n\nExcept for the margin change, this change should be neutral\nin terms of GM results.\n\nBug: skia:301559046\nCq-Include-Trybots: luci.skia.skia.primary:Build-Debian10-Clang-x86_64-Debug-Fontations,Build-Mac-Clang-x86_64-Debug-Fontations,Test-Debian10-Clang-GCE-CPU-AVX2-x86_64-Debug-All-NativeFonts_Fontations,Test-Mac12-Clang-MacBookPro16.2-CPU-AppleIntel-x86_64-Debug-All-NativeFonts_Fontations\nChange-Id: I1ebffad005ff0742dbde6512425cb96163512d3e\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859777\nCommit-Queue: Ben Wagner \nReviewed-by: Ben Wagner \nReviewed-by: Dominik Röttsches \nAuto-Submit: Dominik Röttsches ","shortMessageHtmlLink":"[Fontations-backend] Hinting mode switching compat for comparison test"}},{"before":"b1e59e25696a7b76132c39e4dd88e6bad323b73a","after":"ce975ddfd9fb95eabcc53ae456cefd436f96e9ef","ref":"refs/heads/main","pushedAt":"2024-05-31T15:27:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Optimize conical gradient negations\n\nAddresses the comments left by John Stiles on https://skia-review.googlesource.com/c/skia/+/857916. Saving the cost of 2 negations.\n\nChange-Id: I1b67b9b02dd9dd20b7ce79ed963d2986beb5a506\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860437\nReviewed-by: Michael Ludwig \nReviewed-by: John Stiles \nCommit-Queue: Nathan Sanchez ","shortMessageHtmlLink":"Optimize conical gradient negations"}},{"before":"ddc7ed3f0767c2911492a21edfd3167880aaa25f","after":"b1e59e25696a7b76132c39e4dd88e6bad323b73a","ref":"refs/heads/main","pushedAt":"2024-05-31T15:01:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Re-reland: \"Fix text 565 to RGBA conversion on BGRA-based systems.\"\n\nThis is a re-reland of commit bb02e9152fe4abb34e4ffc5aae7334a1380971ae\n\nOriginal change's description:\n> Fix text 565 to RGBA conversion on BGRA-based systems.\n>\n> On systems where a 565 format isn't supported, we convert to RGBA and\n> use that instead. However, if the base color type for the system is\n> BGRA, we assume the font data is in that format as well, and\n> swizzle it before copying to an RGBA texture. The end result is that\n> we swap R and B, ending up with the incorrect LCD glyph. The solution\n> is to convert 565 data to BGRA data on those systems.\n>\n> Bug: skia:337905340\n> Change-Id: I2b005f977a8af7a3de99d93152c615e595daf4f4\n> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859118\n> Commit-Queue: Jim Van Verth \n> Reviewed-by: Robert Phillips \n\nBug: skia:337905340\nChange-Id: I591b9fa39b07feef0e05db48203b2c116bad0c71\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859064\nReviewed-by: Robert Phillips \nAuto-Submit: Jim Van Verth \nCommit-Queue: Jim Van Verth ","shortMessageHtmlLink":"Re-reland: \"Fix text 565 to RGBA conversion on BGRA-based systems.\""}},{"before":"8cc93368482b200e122c61d54fe1b28d4e1d0e89","after":"ddc7ed3f0767c2911492a21edfd3167880aaa25f","ref":"refs/heads/main","pushedAt":"2024-05-31T13:18:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[graphite] Add displacement ImageFilter to Precompilation system\n\nBug: b/259548724\nChange-Id: I4bbf9677999bd2f3af90fb288f48ea57e436d505\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859062\nReviewed-by: Jim Van Verth \nCommit-Queue: Robert Phillips ","shortMessageHtmlLink":"[graphite] Add displacement ImageFilter to Precompilation system"}},{"before":"64aae6958cc97e0a7a1578884944efa46df4c57a","after":"8cc93368482b200e122c61d54fe1b28d4e1d0e89","ref":"refs/heads/main","pushedAt":"2024-05-31T12:01:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll vulkan-deps from 4a0e77c7168d to 0da3accd42f7 (1 revision)\n\nhttps://chromium.googlesource.com/vulkan-deps.git/+log/4a0e77c7168d..0da3accd42f7\n\nAlso rolling transitive DEPS:\n https://chromium.googlesource.com/external/github.com/KhronosGroup/Vulkan-Headers/+log/5677bafb820e476441e9e1f745371b72133407d3..192d051db3382e213f8bd9d8048fc9eaa78ed6ab\n\nIf this roll has caused a breakage, revert this CL and stop the roller\nusing the controls here:\nhttps://autoroll.skia.org/r/vulkan-deps-skia-autoroll\nPlease CC bwils@google.com,skiabot@google.com on the revert to ensure that a human\nis aware of the problem.\n\nTo file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry\n\nTo report a problem with the AutoRoller itself, please file a bug:\nhttps://issues.skia.org/issues/new?component=1389291&template=1850622\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md\n\nCq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE\nBug: None\nTbr: bwils@google.com\nChange-Id: I2731648abfb0b3c0cdfa124409d84344b44050b2\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859682\nCommit-Queue: skia-autoroll \nBot-Commit: skia-autoroll ","shortMessageHtmlLink":"Roll vulkan-deps from 4a0e77c7168d to 0da3accd42f7 (1 revision)"}},{"before":"47bbc9c6d5f511a6567b66f4a9ea4d65ae616297","after":"64aae6958cc97e0a7a1578884944efa46df4c57a","ref":"refs/heads/main","pushedAt":"2024-05-31T07:21:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll ANGLE from 34b832a32647 to 67036978c265 (7 revisions)\n\nhttps://chromium.googlesource.com/angle/angle.git/+log/34b832a32647..67036978c265\n\n2024-05-31 lexa.knyazev@gmail.com Update Intel PCI IDs\n2024-05-30 angle-autoroll@skia-public.iam.gserviceaccount.com Manual roll vulkan-deps from 1c35ddaeefd9 to f7e762742da9 (1 revision)\n2024-05-30 lehoangquyen@chromium.org Metal: skip copying via parentTexture on iOS simulator.\n2024-05-30 romanl@google.com PPO: Propagate dirty uniforms via mPPOProgramExecutables\n2024-05-30 estaab@chromium.org Add gardener_rotations property\n2024-05-30 syoussefi@chromium.org Vulkan: Use OpSelect with all types with SPIR-V 1.4\n2024-05-30 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 40e780119c08 to 514da917ca32 (624 revisions)\n\nIf this roll has caused a breakage, revert this CL and stop the roller\nusing the controls here:\nhttps://autoroll.skia.org/r/angle-skia-autoroll\nPlease CC bwils@google.com,jmadill@google.com on the revert to ensure that a human\nis aware of the problem.\n\nTo file a bug in ANGLE: https://bugs.chromium.org/p/angleproject/issues/entry\nTo file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry\n\nTo report a problem with the AutoRoller itself, please file a bug:\nhttps://issues.skia.org/issues/new?component=1389291&template=1850622\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md\n\nCq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Build-Mac-Clang-arm64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-AlphaR2-GPU-RadeonR9M470X-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-Golo-GPU-QuadroP400-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC6i5SYK-GPU-IntelIris540-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC8i5BEK-GPU-IntelIris655-x86_64-Debug-All-ANGLE;skia/skia.primary:Test-Win10-Clang-NUCD34010WYKH-GPU-IntelHD4400-x86_64-Debug-All-ANGLE\nTbr: bwils@google.com\nChange-Id: I48f3f87ed338a92583b2443f7274974fa7d5e8cb\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859247\nCommit-Queue: skia-autoroll \nBot-Commit: skia-autoroll ","shortMessageHtmlLink":"Roll ANGLE from 34b832a32647 to 67036978c265 (7 revisions)"}},{"before":"e775da601e2cbf24cb8461d232fa03c297123836","after":"47bbc9c6d5f511a6567b66f4a9ea4d65ae616297","ref":"refs/heads/main","pushedAt":"2024-05-31T06:04:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll SK Tool from 30e89cc94007 to 4e5420fc5c0d\n\nhttps://skia.googlesource.com/buildbot.git/+log/30e89cc94007..4e5420fc5c0d\n\n2024-05-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 1c59100bb494 to 30e89cc94007 (3 revisions)\n\nIf this roll has caused a breakage, revert this CL and stop the roller\nusing the controls here:\nhttps://autoroll.skia.org/r/sk-tool-skia\nPlease CC borenet@google.com,skiabot@google.com on the revert to ensure that a human\nis aware of the problem.\n\nTo file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry\n\nTo report a problem with the AutoRoller itself, please file a bug:\nhttps://issues.skia.org/issues/new?component=1389291&template=1850622\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md\n\nTbr: borenet@google.com\nChange-Id: If62caa7982e13822f5d05a419e97a3699533a42c\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860416\nCommit-Queue: skia-autoroll \nBot-Commit: skia-autoroll ","shortMessageHtmlLink":"Roll SK Tool from 30e89cc94007 to 4e5420fc5c0d"}},{"before":"b34e5dd89e9d2e549aa86f7d2ab3ab532d289dfe","after":"e775da601e2cbf24cb8461d232fa03c297123836","ref":"refs/heads/main","pushedAt":"2024-05-31T05:13:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll Skia Infra from 1c59100bb494 to 30e89cc94007 (3 revisions)\n\nhttps://skia.googlesource.com/buildbot.git/+log/1c59100bb494..30e89cc94007\n\n2024-05-30 mingkong@google.com [golden] Fix diff RPC call on cluster view\n2024-05-30 viditchitkara@google.com Create favorites relational table\n2024-05-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Skia Infra CIPD packages from 57354f93e99c to 1c59100bb494 (3 revisions)\n\nIf this roll has caused a breakage, revert this CL and stop the roller\nusing the controls here:\nhttps://autoroll.skia.org/r/infra-skia\nPlease CC borenet@google.com,skiabot@google.com on the revert to ensure that a human\nis aware of the problem.\n\nTo file a bug in Skia Infra: https://bugs.chromium.org/p/skia/issues/entry\nTo file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry\n\nTo report a problem with the AutoRoller itself, please file a bug:\nhttps://issues.skia.org/issues/new?component=1389291&template=1850622\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md\n\nBug: None\nTbr: borenet@google.com\nChange-Id: I20dd133aff2fc84b564893ee48fe3be9734ef0bd\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860317\nBot-Commit: skia-autoroll \nCommit-Queue: skia-autoroll ","shortMessageHtmlLink":"Roll Skia Infra from 1c59100bb494 to 30e89cc94007 (3 revisions)"}},{"before":"c6cf8be050c0796addd91ee20e3c6adc879a7221","after":"b34e5dd89e9d2e549aa86f7d2ab3ab532d289dfe","ref":"refs/heads/main","pushedAt":"2024-05-30T22:20:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Revert \"Reland \"Fix text 565 to RGBA conversion on BGRA-based systems.\"\"\n\nThis reverts commit 7cfb0898ac158804a46b13ec70b4373c2ac78843.\n\nReason for revert: Chrome Gold will not take rebaselines.\n\nOriginal change's description:\n> Reland \"Fix text 565 to RGBA conversion on BGRA-based systems.\"\n>\n> This is a reland of commit bb02e9152fe4abb34e4ffc5aae7334a1380971ae\n>\n> Original change's description:\n> > Fix text 565 to RGBA conversion on BGRA-based systems.\n> >\n> > On systems where a 565 format isn't supported, we convert to RGBA and\n> > use that instead. However, if the base color type for the system is\n> > BGRA, we assume the font data is in that format as well, and\n> > swizzle it before copying to an RGBA texture. The end result is that\n> > we swap R and B, ending up with the incorrect LCD glyph. The solution\n> > is to convert 565 data to BGRA data on those systems.\n> >\n> > Bug: b/337905340\n> > Change-Id: I2b005f977a8af7a3de99d93152c615e595daf4f4\n> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859118\n> > Commit-Queue: Jim Van Verth \n> > Reviewed-by: Robert Phillips \n>\n> Bug: b/337905340\n> Change-Id: I9bc2beb1153316068da0f761be511497f46d1bff\n> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859978\n> Commit-Queue: Jim Van Verth \n> Reviewed-by: Robert Phillips \n\nBug: b/337905340\nChange-Id: I4fd12e22e5d0243a6f2001dd1251987108f80f7f\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860276\nAuto-Submit: Jim Van Verth \nCommit-Queue: Rubber Stamper \nBot-Commit: Rubber Stamper ","shortMessageHtmlLink":"Revert \"Reland \"Fix text 565 to RGBA conversion on BGRA-based systems.\"\""}},{"before":"a058f601e1fb4c62e53eb034900d68e3959e52ae","after":"c6cf8be050c0796addd91ee20e3c6adc879a7221","ref":"refs/heads/main","pushedAt":"2024-05-30T21:02:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[Graphites] Use SkTo in recent Vulkan DescSet change.\n\nChange-Id: Ib07d0832693c16bf437935b51e242eb2ba974e40\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859398\nCommit-Queue: John Stiles \nReviewed-by: John Stiles \nCommit-Queue: Greg Daniel \nAuto-Submit: Greg Daniel ","shortMessageHtmlLink":"[Graphites] Use SkTo in recent Vulkan DescSet change."}},{"before":"188ad395c3e747617fb60d1feefe6e6626301832","after":"a058f601e1fb4c62e53eb034900d68e3959e52ae","ref":"refs/heads/main","pushedAt":"2024-05-30T20:11:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Roll vulkan-deps from f666a6e01c85 to 4a0e77c7168d (4 revisions)\n\nhttps://chromium.googlesource.com/vulkan-deps.git/+log/f666a6e01c85..4a0e77c7168d\n\nAlso rolling transitive DEPS:\n https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Headers/+log/ea77f2a826bc820cb8f57f9b2a7c7eccb681c731..ff2afc3afc48dff4eec2a10f0212402a80708e38\n https://skia.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools/+log/3d24089292ed357658e3de81ddc2e72f11296e39..142bf7de83b550b549b4049eb1f3dcb2ff007ec1\n\nIf this roll has caused a breakage, revert this CL and stop the roller\nusing the controls here:\nhttps://autoroll.skia.org/r/vulkan-deps-skia-autoroll\nPlease CC bwils@google.com,skiabot@google.com on the revert to ensure that a human\nis aware of the problem.\n\nTo file a bug in skia: https://bugs.chromium.org/p/skia/issues/entry\n\nTo report a problem with the AutoRoller itself, please file a bug:\nhttps://issues.skia.org/issues/new?component=1389291&template=1850622\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md\n\nCq-Include-Trybots: skia/skia.primary:Build-Debian10-Clang-x86_64-Release-ANGLE;skia/skia.primary:Test-Win10-Clang-NUC5i7RYH-GPU-IntelIris6100-x86_64-Debug-All-ANGLE\nBug: None\nTbr: bwils@google.com\nChange-Id: Ib913072c2d79d7728a29ef8e3d83cbce5d33db0e\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/860116\nCommit-Queue: skia-autoroll \nBot-Commit: skia-autoroll ","shortMessageHtmlLink":"Roll vulkan-deps from f666a6e01c85 to 4a0e77c7168d (4 revisions)"}},{"before":"7cfb0898ac158804a46b13ec70b4373c2ac78843","after":"188ad395c3e747617fb60d1feefe6e6626301832","ref":"refs/heads/main","pushedAt":"2024-05-30T19:45:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Change graphite conical gradient implementation\n\nOpted to using the quadratic formula for interpolation to reduce\nbranches. Benchmarking in nanobench resulted in a consistent 5 microsecond decrease which is about a 10~20% improvement upon the previous algorithm.\n\nBug: b/342419895\nChange-Id: Iae0f5eff08a52571061da30f382072adf045d057\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/857916\nCommit-Queue: Nathan Sanchez \nReviewed-by: James Godfrey-Kittle \nReviewed-by: Michael Ludwig ","shortMessageHtmlLink":"Change graphite conical gradient implementation"}},{"before":"243e32491e78ad6124459e5ed8b6e0c07b709d3a","after":"7cfb0898ac158804a46b13ec70b4373c2ac78843","ref":"refs/heads/main","pushedAt":"2024-05-30T18:28:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Reland \"Fix text 565 to RGBA conversion on BGRA-based systems.\"\n\nThis is a reland of commit bb02e9152fe4abb34e4ffc5aae7334a1380971ae\n\nOriginal change's description:\n> Fix text 565 to RGBA conversion on BGRA-based systems.\n>\n> On systems where a 565 format isn't supported, we convert to RGBA and\n> use that instead. However, if the base color type for the system is\n> BGRA, we assume the font data is in that format as well, and\n> swizzle it before copying to an RGBA texture. The end result is that\n> we swap R and B, ending up with the incorrect LCD glyph. The solution\n> is to convert 565 data to BGRA data on those systems.\n>\n> Bug: b/337905340\n> Change-Id: I2b005f977a8af7a3de99d93152c615e595daf4f4\n> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859118\n> Commit-Queue: Jim Van Verth \n> Reviewed-by: Robert Phillips \n\nBug: b/337905340\nChange-Id: I9bc2beb1153316068da0f761be511497f46d1bff\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859978\nCommit-Queue: Jim Van Verth \nReviewed-by: Robert Phillips ","shortMessageHtmlLink":"Reland \"Fix text 565 to RGBA conversion on BGRA-based systems.\""}},{"before":"13e829064e8ce8acc39512abfa7df547bf5b7979","after":"243e32491e78ad6124459e5ed8b6e0c07b709d3a","ref":"refs/heads/main","pushedAt":"2024-05-30T18:02:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[graphite] Rm unused attribute and correct format logic\n\n* These changes should have been within https://skia-review.googlesource.com/c/skia/+/825836 but were accidentally omitted or clobbered when rebasing.\n\nChange-Id: I544a2b0200cf4dd4a343a305bbdda1db1c772da3\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859800\nCommit-Queue: Nicolette Prevost \nReviewed-by: Nolan Scobie ","shortMessageHtmlLink":"[graphite] Rm unused attribute and correct format logic"}},{"before":"75cf7d351b0219a9433798a00237da68af91040c","after":"13e829064e8ce8acc39512abfa7df547bf5b7979","ref":"refs/heads/main","pushedAt":"2024-05-30T17:37:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Fix duplicated sources in ganesh_vulkan rule\n\nFollow-up to https://skia-review.googlesource.com/c/skia/+/859057\n\nChange-Id: I68cb7b67d63063b86bca3c58a0291686b90dc78e\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859799\nReviewed-by: Brandon Wilson \nReviewed-by: Nicolette Prevost ","shortMessageHtmlLink":"Fix duplicated sources in ganesh_vulkan rule"}},{"before":"eadc654480ed86afc5c1b7ef4d55c7cc19e2f4db","after":"75cf7d351b0219a9433798a00237da68af91040c","ref":"refs/heads/main","pushedAt":"2024-05-30T16:47:36.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Revert \"[Ganesh] Make GL Protectedness behave more like Vulkan Protectedness\"\n\nThis reverts commit 8da05c8d40af614e3fdc7c94265bebee0e6b0ca6.\n\nReason for revert: Failing Protected tests\n\nOriginal change's description:\n> [Ganesh] Make GL Protectedness behave more like Vulkan Protectedness\n>\n> Ganesh Vulkan promotes all images to Protected status for Protected GrContexts. This CL makes Ganesh GL do the same thing.\n>\n> This has the effect of ensuring all images associated with/used by a given GrContext have a Protectedness matching the Context's.\n>\n> Bug: b/318636997\n> Change-Id: I01aef5ac3852e3a12c9ae83892bb687a0c96ed5a\n> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/851057\n> Reviewed-by: Greg Daniel \n> Commit-Queue: Robert Phillips \n\nBug: b/318636997\nChange-Id: I0e986911801d8388dc5ee66122aa21f8e0b2fde1\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859977\nAuto-Submit: Robert Phillips \nCommit-Queue: Rubber Stamper \nBot-Commit: Rubber Stamper ","shortMessageHtmlLink":"Revert \"[Ganesh] Make GL Protectedness behave more like Vulkan Protec…"}},{"before":"675b8ff1cdb5d05f0e5ec7e72a708461a1ec9c65","after":"eadc654480ed86afc5c1b7ef4d55c7cc19e2f4db","ref":"refs/heads/main","pushedAt":"2024-05-30T15:55:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[Graphite] Add descriptor set cache for Vulkan uniforms.\n\nThis adds a cache of written descriptor sets used for binding\nvulkan uniform buffers. The cache key is based off keying each\nbinding of the set. A binding is keyed using the buffers uniqueID\nand the size/range of the binding.\n\nTo allow for reuse of these descriptor sets, we now always use\ndynamic uniform descriptors. To do this we always write the\ndescriptor with an offset of 0 and then set the correct offset\nwhen we bind the set.\n\nA future optimization to this caching is to track the last\nbound desc set on the command buffer to be able to quickly check\nif that desc set can be used again without needing to generate\na key and do the cache look up. Running through the skps\nabout 50% of the time we get a desc set from the cache it is the\nsame as the previously used one.\n\n\nChange-Id: I5d0cf8b25bea4f3b87d6d93a4fbd41b7fec975af\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/854437\nReviewed-by: Nicolette Prevost \nCommit-Queue: Greg Daniel ","shortMessageHtmlLink":"[Graphite] Add descriptor set cache for Vulkan uniforms."}},{"before":"7d20c03e375571302bee8f1f216c45203fee3cb6","after":"675b8ff1cdb5d05f0e5ec7e72a708461a1ec9c65","ref":"refs/heads/main","pushedAt":"2024-05-30T15:29:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Add link deps to lowest skia_cc_library\n\nWhen compiling/linking for android, if we have these linkopts too far\nup the dependency tree, things seem to not always work.\n\nBug: b/293490566\nChange-Id: I327be9bed7537d1dc65af16a891c026f2593f00a\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859796\nReviewed-by: Nolan Scobie ","shortMessageHtmlLink":"Add link deps to lowest skia_cc_library"}},{"before":"693d9362f0f697a9f31e2cd98d057a6493e597c5","after":"7d20c03e375571302bee8f1f216c45203fee3cb6","ref":"refs/heads/main","pushedAt":"2024-05-30T15:03:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Reland \"[skif] Take advantage of PixelBoundary in rescale()\"\n\nThis reverts commit 2fe794827c51c99b57c6bd8de54ec5a5f764a546.\n\nReason for revert: adjusted filterresult thresholds for debian and mali400\n\nOriginal change's description:\n> Revert \"[skif] Take advantage of PixelBoundary in rescale()\"\n>\n> This reverts commit ac454b80130cdf90a74b36b067a2284ce12375fa.\n>\n> Reason for revert: Blocking Android roll + red bots\n>\n> Original change's description:\n> > [skif] Take advantage of PixelBoundary in rescale()\n> >\n> > Change-Id: Ie6d5b43f0a74035e9f4e785330931e856905a25c\n> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/816517\n> > Reviewed-by: Robert Phillips \n> > Commit-Queue: Michael Ludwig \n>\n> Change-Id: I8714217d96db2a3e0f4a906a1d6949fc1130722d\n> No-Presubmit: true\n> No-Tree-Checks: true\n> No-Try: true\n> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859120\n> Auto-Submit: Robert Phillips \n> Commit-Queue: Rubber Stamper \n> Bot-Commit: Rubber Stamper \n\nChange-Id: I32236abbdc9f1c237528cf93f2dc31f72a490f98\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859121\nCommit-Queue: Michael Ludwig \nReviewed-by: Robert Phillips ","shortMessageHtmlLink":"Reland \"[skif] Take advantage of PixelBoundary in rescale()\""}},{"before":"56b82ce62da78f01cd164c4645ae4769c567be37","after":"693d9362f0f697a9f31e2cd98d057a6493e597c5","ref":"refs/heads/main","pushedAt":"2024-05-30T14:37:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Revert \"Fix text 565 to RGBA conversion on BGRA-based systems.\"\n\nThis reverts commit bb02e9152fe4abb34e4ffc5aae7334a1380971ae.\n\nReason for revert: Causing pixel test issues on Chrome. Not sure\nif it's fixing an error or not.\n\nOriginal change's description:\n> Fix text 565 to RGBA conversion on BGRA-based systems.\n>\n> On systems where a 565 format isn't supported, we convert to RGBA and\n> use that instead. However, if the base color type for the system is\n> BGRA, we assume the font data is in that format as well, and\n> swizzle it before copying to an RGBA texture. The end result is that\n> we swap R and B, ending up with the incorrect LCD glyph. The solution\n> is to convert 565 data to BGRA data on those systems.\n>\n> Bug: b/337905340\n> Change-Id: I2b005f977a8af7a3de99d93152c615e595daf4f4\n> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/859118\n> Commit-Queue: Jim Van Verth \n> Reviewed-by: Robert Phillips \n\nBug: b/337905340\nChange-Id: I455e1d347aa4eb298f2b3a614263329a3e4879de\nNo-Presubmit: true\nNo-Tree-Checks: true\nNo-Try: true\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859798\nCommit-Queue: Rubber Stamper \nAuto-Submit: Jim Van Verth \nBot-Commit: Rubber Stamper ","shortMessageHtmlLink":"Revert \"Fix text 565 to RGBA conversion on BGRA-based systems.\""}},{"before":"949b8cefbf87776b257b54176c46cefa34b17a26","after":"56b82ce62da78f01cd164c4645ae4769c567be37","ref":"refs/heads/main","pushedAt":"2024-05-30T14:12:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[skif] Disable padding on dithered FilterResults\n\nChromium still has SK_DONT_PAD_LAYER_IMAGES defined, due to WPT ref\ntest failures where the dither origin shifts between a regular draw\nof a gradient shader and one where it's embedded in an image filter.\n\nIt also requires additional regular layout test rebaselines to\ndeal with interpolation/rendering differences for cases where there is\npadding. This is manageable but the WPT ref tests require changes to\nbehavior to be able to remove the #define (since implementing dither\norigin control is non-trivial).\n\nWhen SK_DONT_PAD_LAYER_IMAGES is defined, the AutoSurface constructor\nalways uses PixelBoundary::kUnknown regardless of what was passed in.\nThese changes modify the behavior for when SK_DONT_PAD_LAYER_IMAGES\nis not defined and makes it so that when dithering would be used in\nan image-filtering context we don't pad the offscreen surfaces.\n\nPS1 tested the change against chrome by removing all pound defines and\nthe WPT tests passed, so once this change lands, it should be possible\nto stage the removal of SK_DONT_PAD_LAYER_IMAGES in chrome.\n\nBug: b/329700315\nChange-Id: I294b1d493c16440613a5c71aaf7abf31ae90513e\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859376\nReviewed-by: Robert Phillips \nCommit-Queue: Michael Ludwig ","shortMessageHtmlLink":"[skif] Disable padding on dithered FilterResults"}},{"before":"8da05c8d40af614e3fdc7c94265bebee0e6b0ca6","after":"949b8cefbf87776b257b54176c46cefa34b17a26","ref":"refs/heads/main","pushedAt":"2024-05-30T13:46:36.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"Enforce IWYU on src/gpu/vk\n\nBug: b/293490566, b/40044159\nChange-Id: I5cae1f19077b0754fa13cedc3635f403e0f6c137\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859117\nOwners-Override: Kaylee Lubick \nReviewed-by: Nicolette Prevost ","shortMessageHtmlLink":"Enforce IWYU on src/gpu/vk"}},{"before":"69980ce8d04144b41adbc5cc194f29adbc12ceaa","after":"be621ea04206d8fae23952783d1d588d6ce0d9b3","ref":"refs/heads/chrome/m126","pushedAt":"2024-05-30T13:20:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"hubot","name":"Hubot","path":"/hubot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/480938?s=80&v=4"},"commit":{"message":"[Ganesh] Fix readPixels for planar textures on Vulkan.\n\nWhen the underlying format is planar,\nGrVkCaps::surfaceSupportsReadPixels returns kCopyToTexture2D. Because\nthe color type is kRGB_888x and kRGB_888x is not renderable on Vulkan,\nthe allocation of the temporary surface fails.\n\nWhen we know the allocation will fail, fall back to kRGBA_8888 instead.\n\nBug: b/339242357\nChange-Id: Ia5b3324dab4794bd2513a006a2aea157d5baf5ee\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/856296\nCommit-Queue: Chia-I Wu \nReviewed-by: Greg Daniel \n(cherry picked from commit ba0db3c0ab89147f3f71869d03182a4f0c40be55)\nReviewed-on: https://skia-review.googlesource.com/c/skia/+/859556\nCommit-Queue: Greg Daniel ","shortMessageHtmlLink":"[Ganesh] Fix readPixels for planar textures on Vulkan."}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWXvG7gA","startCursor":null,"endCursor":null}},"title":"Activity · google/skia"}