Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project owners need some way to mark bugs as false positives #11925

Open
davidben opened this issue May 8, 2024 · 3 comments
Open

Project owners need some way to mark bugs as false positives #11925

davidben opened this issue May 8, 2024 · 3 comments

Comments

@davidben
Copy link
Contributor

davidben commented May 8, 2024

It's pretty frequent that OSS-Fuzz infrastructure changes cause false positives (see #11881). This historically hasn't been a big deal, because we can just ignore them.

However, since then, these false positives are now automatically imported into OSV. As a result, the false positives will cause a ton of busywork in downstream systems until an incredibly manual process can withdraw them: google/oss-fuzz-vulns#37

As a result, ignoring false positives is no longer viable. Project owners need to have some mechanism to mark bugs as false positives.

@davidben
Copy link
Contributor Author

davidben commented May 8, 2024

A related issue: #6974

@evverx
Copy link
Contributor

evverx commented May 8, 2024

I think it would be great if this whole process was improved. When CVEs were assigned (semi?) automatically based on OSV data I kind of started withdrawing entires like google/oss-fuzz-vulns#35 and google/oss-fuzz-vulns#25 but then stopped because CVEs were seemingly gone and the other OSV consumers like scorecard with their "vulnerabilities" don't matter to me.

@davidben
Copy link
Contributor Author

To make sure everyone is on the same page here, false positives here doesn't mean there was a subjective disagreement over whether an issue had security consequences. False positives here means the issue did not exist. OSS-Fuzz has false positives all the time when the compiler infrastructure needed to check for uninitialized memory, or other errors, broke. Most recently, it looks like the instrumented C/C++ runtime did not get picked up, so it mistakenly believed all strings were uninitialized.

A user of the project could not apply a fix for this issue, because there is nothing to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants