Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectionManager is unable to distinguish the same device when discovered multiple times #1877

Open
jmg-duarte opened this issue Jun 28, 2023 · 2 comments
Labels
lang: swift An issue with a Swift client library P3 Priority 3 issue (default for bugs or new feature requests; things we'd like to work on) project: connections An issue with the Connections project type: bug Something is broken or not working as intended

Comments

@jmg-duarte
Copy link

jmg-duarte commented Jun 28, 2023

Project

Nearby Connections Examples

Language

Swift

OS Platform

Apple

What happened?

I'm using the iOS example applications, completely out of the box, on the following devices:

  • iPhone 13 - iOS 16.5.1
  • iPad Air - iPadOS 16.5.1

And the following happens:

RPReplay_Final1687951904.MP4

This is not app related, as I've ran into this issue on an app I'm developing before testing with the example.
It's also not strategy related as I'm running Point-to-Point on my app and Cluster on the example.

What did you expect to happen?

The device list should not have duplicates.

How can we reproduce it (as minimally and precisely as possible)?

  1. Start advertising on device 1
  2. Start discovery on device 2
  3. Toggle discovery between on and off several times
  4. See the list grow

How often does this bug happen?

Every time

Standalone code to reproduce the issue

NA

Relevant log output

NA

Anything else we need to know?

NA

@jmg-duarte jmg-duarte added needs-triage Issue still needs to be assigned, labeled and deduplicated type: bug Something is broken or not working as intended labels Jun 28, 2023
@jmg-duarte
Copy link
Author

I just noticed that the issue lies in the usage of an Array rather than an Map, not sure if you will want to improve the example or keep it as it is so for now I'm leaving the issue open

@bourdakos1
Copy link
Collaborator

You’re welcome to submit a pull request if you have a fix, otherwise I can take a look :)

@bourdakos1 bourdakos1 added lang: swift An issue with a Swift client library project: connections An issue with the Connections project P3 Priority 3 issue (default for bugs or new feature requests; things we'd like to work on) and removed needs-triage Issue still needs to be assigned, labeled and deduplicated labels Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: swift An issue with a Swift client library P3 Priority 3 issue (default for bugs or new feature requests; things we'd like to work on) project: connections An issue with the Connections project type: bug Something is broken or not working as intended
Projects
None yet
Development

No branches or pull requests

2 participants