Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation Playback Track not calling Play on target AnimationPlayer with timestamp 0 #91554

Closed
TheOrioli opened this issue May 4, 2024 · 5 comments
Closed

Animation Playback Track not calling Play on target AnimationPlayer with timestamp 0 #91554

TheOrioli opened this issue May 4, 2024 · 5 comments
Labels
topic:animation
Milestone
4.3

Comments

@TheOrioli
Copy link

Tested versions

  • v4.3.dev6.official [89850d5]
  • v4.2.2.stable.mono.official [15073af]
  • v4.1.3.stable.mono.official [f06b6836a] <- issue is not reproducible in this version

System information

Godot v4.2.2.stable.mono - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2070 SUPER (NVIDIA; 31.0.15.5212) - AMD Ryzen 9 3900X 12-Core Processor (24 Threads)

Issue description

It seems that the AnimationPlaybackTrack doesn't call Play properly on the targeted AnimationPlayer if the track keyframe is set to 0.

Adjusting to 0.001 seconds works.
The issue doesn't appear in v4.1.3

Steps to reproduce

  1. Open MRP
  2. Using the PlayThisAnimationPlayer play the broken animations.
  3. Notice that the Label text doesn't change during the first value in the animation track
  4. Play the animation called non_zero_start_work
  5. Notice that the Label text changes

Minimal reproduction project (MRP)

animationtrack-repro.zip
@AThousandShips
Copy link
Member

Sounds like the same as:

@TheOrioli
Copy link
Author

Is #90960 included in v4.3.dev6.official?

@AThousandShips
Copy link
Member

No it was merged after

@TheOrioli
Copy link
Author

I'll give this a test tomorrow on master in that case 👍

@TheOrioli
Copy link
Author

Fixed on master 🙌

@AThousandShips AThousandShips added this to the 4.3 milestone May 5, 2024
Poobslag added a commit to Poobslag/frog-finder that referenced this issue May 16, 2024
@Poobslag
Godot bug workaround for animation playback tracks
f294130 
Godot 4.2.2 introduced Godot #91554
(godotengine/godot#91554), a bug with AnimationPlayer
where AnimationPlaybackTrack doesn't call Play properly on the targeted
AnimationPlayer if the track keyframe is set to 0.

A time of 0.001 works.
@Poobslag Poobslag mentioned this issue May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic:animation
Projects
None yet
Milestone
4.3
Development

No branches or pull requests
2 participants
@TheOrioli @AThousandShips