Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: add cloudflare access #9713

Merged
merged 32 commits into from
May 30, 2024

Conversation

4d62
Copy link
Contributor

@4d62 4d62 commented May 13, 2024

Details

closes #9710

documents how to protect selfhosted applications with cloudflare access and authentik


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

Copy link

netlify bot commented May 13, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit 8ee5785
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66565f6774490c0008a4e35f
😎 Deploy Preview https://deploy-preview-9713--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 13, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 8ee5785
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66565f674e5fd90008856139

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.63%. Comparing base (fd66be9) to head (8ee5785).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9713      +/-   ##
==========================================
- Coverage   92.64%   92.63%   -0.01%     
==========================================
  Files         710      710              
  Lines       34706    34744      +38     
==========================================
+ Hits        32152    32185      +33     
- Misses       2554     2559       +5     
Flag Coverage Δ
e2e 49.66% <ø> (-0.01%) ⬇️
integration 25.49% <ø> (-0.02%) ⬇️
unit 90.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@4d62 4d62 changed the title [DRAFT] docs/integrations: document cloudflare access docs/integrations: document cloudflare access May 14, 2024
@4d62 4d62 marked this pull request as ready for review May 14, 2024 00:21
@4d62 4d62 requested a review from a team as a code owner May 14, 2024 00:21
4d62 added 2 commits May 14, 2024 00:27
Signed-off-by: 4d62 <157558804+4d62ext@users.noreply.github.com>
@rissson rissson changed the title docs/integrations: document cloudflare access website/integrations: add cloudflare access May 14, 2024
Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @4d62ext for this great contribution! And apologies for all of my style nit-picks... as I explained in one of the comments I need to do a better job of making our Style Guide more visible... and expanding it a lot.

Thanks again, as soon as you can make those changes let's get this merged!

website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
website/integrations/services/cloudflare-access/index.mdx Outdated Show resolved Hide resolved
4d62 and others added 12 commits May 28, 2024 18:34
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
4d62 and others added 10 commits May 28, 2024 18:38
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Co-authored-by: Tana M Berry <tanamarieberry@yahoo.com>
Signed-off-by: 4d62 <ext@4d62.me>
Signed-off-by: 4d62 <ext@4d62.me>
@4d62 4d62 requested a review from tanberry May 28, 2024 22:49
@4d62
Copy link
Contributor Author

4d62 commented May 28, 2024

I've noticed that integration documentation varies greatly in style—from the inclusion of images to the use of numbers in headers, and more. I'd be happy to update older documentation to match the new style guide you mentioned once it's released, if needed.

@tanberry
Copy link
Contributor

@4d62ext you're right, the variation amongst the Integrations docs is wild... I have been sorta kinda trying to get a hold on it all, but haven't managed to yet. Your help, as much or as little as you have time for, would be greatly appreciated.

I think that the biggest variations are in the headers (as you pointed out), the capitalization, and the ordering of the sections (sometimes authentik is first, sometimes it is last). And yes, also the use of numbered Steps. That is something I struggle with even in our regular docs; whether or not to use numbered steps. It has become less and less common, but my old-fashioned self thinks they are very useful. Sometimes several steps can be grouped together into one section, and that section labeled Step 1 ... as opposed to numbering literally every line and having 27 steps, lol. But it is a tricky one. I'd like your input on whether it makes sense in the Integration docs.

Finally, I did just push a PR #9900 with our baby Style Guide... we are open to input on that as well; it's just a start.

Thank you for all your help with authentik!

@tanberry
Copy link
Contributor

Oh, forgot to say... in general, I'd like to limit the use of screenshots/images in the docs (too much maintenance). The only time we want to use them is if there is a particularly difficult-to-find UI element, and we need to show where it is.

Copy link
Contributor

@tanberry tanberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @4d62ext !

@4d62
Copy link
Contributor Author

4d62 commented May 29, 2024

@tanberry I personally find it better if it is streamlined it into just a list of steps without necessarily distinguishing between the two sections. It feels less cramped and also allows proper headers and sections (Ex: steps directly in h2 instead of authentik Settings being h2 and a step being h3) As for the numbering in headers, I'm inclined to agree with you. Most documentation pages are self-explanatory and a chunk of the images could be removed. I'll open a few pull requests once the style guide is released and my contribution in #9899 is marked ready for review. It is simply renaming functions so it should not take too much time. Mabye a few test fixes as well.

@tanberry tanberry merged commit 66a1675 into goauthentik:main May 30, 2024
62 of 67 checks passed
@tanberry
Copy link
Contributor

Thanks again, @4d62ext ! I am not sure if I prefer the way you did it, with the H2s being steps that continue in numbering through the two sections, or keeping the authentik config and service config as separate sections with separately numbered steps. I'll have a chat with the team and tweak the template (that no one can find anyway haha) to reflect the decision.

But in the meantime let's get this important integration doc out there! :-)

@4d62 4d62 deleted the docs/cf-access-service-setup branch May 31, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloudflare Access Guide
2 participants