Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disturbing interface #7022

Open
fulldump opened this issue May 15, 2024 · 3 comments
Open

Disturbing interface #7022

fulldump opened this issue May 15, 2024 · 3 comments
Labels

Comments

@fulldump
Copy link

Redefine the extremely wide used Writer interface does not make the best of the experiences for the developer:

type Writer interface {
	Printf(string, ...interface{})
}

https://github.com/go-gorm/gorm/blob/master/logger/logger.go#L49-L53

Any plans to have a simpler logger constructor? or even use the most recent structured log from stdlib?

@github-actions github-actions bot added the type:missing reproduction steps missing reproduction steps label May 15, 2024
Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

@ivila
Copy link

ivila commented May 16, 2024

@fulldump You can just redefined the whole logger and replace the default one.

The logger must match the interface defined here:

type Interface interface {

You can set your own logger by setting the Logger value in gorm.Config:

gorm/gorm.go

Line 30 in 5e599a0

Logger logger.Interface

Copy link

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants