Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open this line in github" should use permalinks #71147

Open
asottile-sentry opened this issue May 18, 2024 · 0 comments
Open

"Open this line in github" should use permalinks #71147

asottile-sentry opened this issue May 18, 2024 · 0 comments

Comments

@asottile-sentry
Copy link
Member

asottile-sentry commented May 18, 2024

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Open an issue from a previous code version where the code has changed around the error location (such as https://sentry.sentry.io/issues/5367399422/?project=1&referrer=github-pr-bot)
  2. Click open with github -- in this example the link it produces is https://github.com/getsentry/getsentry/blob/master/getsentry/api/customer_details.py#L252
  3. L252 was only correct in the original code revision, the link should look like (taking the revision from the error): https://github.com/getsentry/getsentry/blob/c56be7d4c78e/getsentry/api/customer_details.py#L252 which correctly points at the actual line

Expected Result

^ filled in inline above

Actual Result

^ filled in inline above

Product Area

Issues

Link

https://sentry.sentry.io/issues/5367399422/?project=1&referrer=github-pr-bot

DSN

n/a

Version

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant