Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alert Github PR author of suspect commit #71127

Open
chodges15 opened this issue May 17, 2024 · 4 comments
Open

Alert Github PR author of suspect commit #71127

chodges15 opened this issue May 17, 2024 · 4 comments
Labels
Product Area: Alerts Sync: Jira apply to auto-create a Jira shadow ticket Type: Feature Request

Comments

@chodges15
Copy link

chodges15 commented May 17, 2024

Problem Statement

Assume a Sentry user merges a Github PR which gets pushed out to production and Sentry reports a new issue with a suspect commit. It is unlikely that the author will notice the suspect commit comment from the Sentry bot.

Relying on auto-assignment of the Sentry issue for the notification is a little risky due to the possibility for Github API rate limits getting hit. Also, auto-assignment of Sentry issues may go to a team instead of an individual, and at the team level the alerts could be noisy causing the original PR author to miss the notification.

If suspect commits are missed and the issue isn't severe enough to trigger an alert, those going unnoticed will lead to stale issues indefinitely accumulating creating unnecessary noise.

Solution Brainstorm

Given the high value of the information Sentry is surfacing here, it would be helpful to enable a targeted alert to the PR author when a suspect commit is identified. This would have the benefit of that author not having to manually look for new issues when their change rolls to production saving them time and making them more efficient.

A direct Slack message is orders of magnitude more likely to be seen and acted upon than a Github PR comment, and targeting it to the PR author ensures the person with the most context is brought in as soon as possible.

Product Area

Alerts

┆Issue is synchronized with this Jira Improvement by Unito

@getsantry
Copy link
Contributor

getsantry bot commented May 17, 2024

Assigning to @getsentry/support for routing ⏲️

@irodrigues-git irodrigues-git added the Sync: Jira apply to auto-create a Jira shadow ticket label May 17, 2024
@getsantry
Copy link
Contributor

getsantry bot commented May 20, 2024

Routing to @getsentry/product-owners-alerts for triage ⏲️

@rachrwang
Copy link

Thank you for filing this @chodges15! Have you tried creating an alert that sends to 'Suggested Assignees'? I think that would address some of the gaps you listed above, while also accounting for suspect commits.

@rachrwang
Copy link

One possible solution is a new workflow notification type to send notifications to the author of suspect commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product Area: Alerts Sync: Jira apply to auto-create a Jira shadow ticket Type: Feature Request
Projects
Status: No status
Development

No branches or pull requests

4 participants