Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: IOx instances that throw exceptions are a mess #24

Open
getify opened this issue Apr 15, 2022 · 0 comments
Open

Bug: IOx instances that throw exceptions are a mess #24

getify opened this issue Apr 15, 2022 · 0 comments

Comments

@getify
Copy link
Owner

getify commented Apr 15, 2022

The error handling story around IOx is embarrassingly buggy and insufficient.

  • exceptions during IOx effect running leave the instance in an inconsistent state where it can't be cleanly re-run
  • chaining an IOx runs it twice (once while registering the listener, then runs it directly)
  • registering an exception-throwing IOx as a dependency leaves the parent IOx in an inconsistent state
  • exceptions don't have any way to propagate from one IOx instance to another in a chain
  • etc etc etc

Need an onError(..) and offError(..) to register handlers to listen for exceptions in IOx instances, and need exception notifications to propagate down an IOx chain until it finds registered listener(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant