Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

performFind does not move to next match if highlight=true #1112

Open
thenbe opened this issue Mar 21, 2024 · 1 comment
Open

performFind does not move to next match if highlight=true #1112

thenbe opened this issue Mar 21, 2024 · 1 comment

Comments

@thenbe
Copy link

thenbe commented Mar 21, 2024

Reproduction

  1. Add this to your mappings.

    map n performFind last highlight
    
  2. Go to https://news.ycombinator.com

  3. Type /

  4. Type com

  5. Hit Enter

  6. Hit n

  7. .

    • EXPECTED: move to next match on every time you hit n
    • ACTUAL: no movement when you press n

Other

The issue is just with performFind. performBackwardsFind behaves as expected.

# this works fine
map N performBackwardsFind last highlight

This bug is rather old so I don't think it is caused by any recently added code.

Browser, OS and Vimium C versions

  • Browser name: firefox
  • Browser version: 123.0.1
  • Vimium C version: 1.99.997
  • OS name and version: "x86_64-linux" Linux 6.6.22, NixOS, 24.05 (Uakari)
@gdh1995
Copy link
Owner

gdh1995 commented May 19, 2024

Confirmed. Seems a bug only happening on Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants