Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup from TypeScript file only searches JavaScript #79

Open
medmunds opened this issue Mar 7, 2019 · 2 comments
Open

Lookup from TypeScript file only searches JavaScript #79

medmunds opened this issue Mar 7, 2019 · 2 comments

Comments

@medmunds
Copy link

medmunds commented Mar 7, 2019

Searches for TypeScript features in a .ts file seem to end up in the JavaScript section of Dash.

To reproduce:

  1. Create file foo.ts (in, say, WebStorm):
interface Foo {
  bar: string;
}
  1. Position the caret in interface and press Cmd-Shift-D.

Results: searches for "javascript: interface". (And I have Node docset installed, so it finds a match there.)
screen shot 2019-03-07 at 2 14 32 pm

Expected: should search for "typescript: interface"
screen shot 2019-03-07 at 2 15 04 pm

Dash plugin v3.3
WebStorm 2018.3.5
Dash v4.6.2

@gdelmas
Copy link
Owner

gdelmas commented Mar 7, 2019

you are right. when searching in typescript files it should prioritize the results from the typescript docset, yet still search in all the docsets defined for javascript. as the javascript commands and api still apply.

i'll add this.

@steven130169
Copy link

same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants