Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Change the Github API "error" message into "suggestion" #43

Open
illBeRoy opened this issue Apr 17, 2021 · 1 comment
Open

Comments

@illBeRoy
Copy link

Today, if scaffolder fails to use Github API, it shows the following error:
image

This is a little be confusing IMO, as it gives the impression that the process has failed, even though it continues right after.

My suggestion: instead of displaying it as an error, write:

Cloning templates from github...
(hint: you can use a Github API token to make this process faster - read about it here <- link to readme)

And not show it every run (like, in a 1 to 5 probability).

WDYT?

If you're down to it, lmk and I'll contribute a PR.

@galElmalah
Copy link
Owner

Sounds great although I don't support API keys. It might be better to just clone the entire repo always (it's happening down the line anyway) instead of fetching the list of templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants