Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuseml current codeset/project may be confusing #244

Open
jsuchome opened this issue Sep 22, 2021 · 2 comments
Open

fuseml current codeset/project may be confusing #244

jsuchome opened this issue Sep 22, 2021 · 2 comments
Labels
area/cli CLI features and behavior

Comments

@jsuchome
Copy link
Member

When new codeset is registered, it's automatically marked as "current". That seems nice because it's not necessary to provide codeset for further actions.

However it is also confusing, because e.g. 'codeset list' command will automatically use the "current" values and filter the results, so you do not see all items when you'd expect them

@jsuchome jsuchome added the area/cli CLI features and behavior label Sep 22, 2021
@jsuchome jsuchome added this to Backlog in FuseML Project Board via automation Sep 22, 2021
@jsuchome jsuchome moved this from Backlog to Current Iteration in FuseML Project Board Sep 22, 2021
jsuchome added a commit to jsuchome/fuseml-core that referenced this issue Sep 29, 2021
When current codeset is saved in config file, 'codeset list' command
always uses it to filter the results. This might not be wanted, so
let's add '--all' option to ignore the filters.

Related to fuseml/fuseml#244
@jsuchome
Copy link
Member Author

jsuchome commented Nov 18, 2021

So with fuseml/fuseml-core#113 , one can list all codesets with --all option:

fuseml codeset list --help
Retrieve information about Codesets registered in FuseML

Usage:
  fuseml codeset list [-p|--project PROJECT] [-l|--label LABEL] [--all] [--format {json,yaml,csv,table}] [--field COLUMN[:FIELD]]... [flags]

Flags:
      --all              show all codesets; ignores 'label' and 'project' options (default: false)

This is helpful I think but user has to know about it. I'm still not sure if we should do more.

  • Maybe we need to explicitly write the project and codeset name whenever a command is called.
    (it's already there for codest list command btw)
  • We definitely need to add --all option to other artefacts, e.g. for workflows, otherwise default filtering would kick in

@jsuchome
Copy link
Member Author

Also related: fuseml/fuseml-core#117

@stefannica stefannica moved this from Current Iteration to Backlog in FuseML Project Board Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli CLI features and behavior
Projects
Development

No branches or pull requests

1 participant