Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

background image (grpc-bg.svg) is too large #316

Open
lqs opened this issue Apr 27, 2024 · 1 comment
Open

background image (grpc-bg.svg) is too large #316

lqs opened this issue Apr 27, 2024 · 1 comment

Comments

@lqs
Copy link

lqs commented Apr 27, 2024

The background image (grpc-bg.svg) is significantly large in size (1.7MB). When embedded into servers with limited bandwidth, it consumes a significant portion of the available resources and results in slower load times.

Please consider replacing the existing image with a simpler pattern or opt for a plain color background.
@dragonsinth dragonsinth mentioned this issue Apr 27, 2024
Merged
@dragonsinth
Copy link
Member

You right. #317

dragonsinth added a commit that referenced this issue Apr 29, 2024
@dragonsinth
replace background image (grpc-bg.svg) with a simple gradient (#317)
a84a94c 
#316

> The background image (grpc-bg.svg) is significantly large in size
(1.7MB). When embedded into servers with limited bandwidth, it consumes
a significant portion of the available resources and results in slower
load times.
> 
> Please consider replacing the existing image with a simpler pattern or
opt for a plain color background.

Before:

<img width="735" alt="Screenshot 2024-04-27 at 11 29 56 AM"
src="https://github.com/fullstorydev/grpcui/assets/1919660/19d65eb2-38fa-4a42-a2ca-331911766c9d">

After:

<img width="732" alt="Screenshot 2024-04-27 at 11 31 33 AM"
src="https://github.com/fullstorydev/grpcui/assets/1919660/4e89e990-d635-4443-a6e2-1e4628494911">

Any feedback on the exact color choices is welcome.
CC: @lqs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lqs @dragonsinth