Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the kotlin version to 1.6.10 to avoid failing builds when use… #71

Closed
wants to merge 1 commit into from
Closed

Update the kotlin version to 1.6.10 to avoid failing builds when use… #71

wants to merge 1 commit into from

Conversation

prasadsunny1
Copy link

…d in a flutter modules

This fixes #70

@countryst
Copy link

When would this be released? Is there a way I can use this in my flutter application?

@prasadsunny1
Copy link
Author

Yes @countryst, You can add add the kotlin version in your host project's build.gradle to temporarily make it build

@countryst
Copy link

  flutter_sms:
    git:
      url: https://github.com/fluttercommunity/flutter_sms.git
      ref: 419918ed46f1c4c675224546778a093e9fd09ca9 # commit hash

This worked https://stackoverflow.com/a/68784015/2603238

repositories {
google()
jcenter()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to switch to mavenCentral? This SO post suggests jcenter is more secure and offers better CDN performance.

https://stackoverflow.com/questions/50726435/difference-among-mavencentral-jcenter-and-mavenlocal

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is an official note from android.
https://developer.android.com/studio/build/jcenter-migration

Jcenter is being deprecated in favour of maven central

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, thanks for the heads up. This wound up being the root cause of some issues with some of my transient dependencies.

@prasadsunny1
Copy link
Author

What do yo think about this PR?
is it good to go in?

@kmcgill88
Copy link
Contributor

@rodydavis anyway there can be more contributors added to help get some of these prs merged?

@kvenn
Copy link

kvenn commented Aug 31, 2023

The fix was merged back in june. This can be closed.

#81

@prasadsunny1 prasadsunny1 closed this by deleting the head repository Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project fails to when a flutter module depends on it
5 participants