Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shifted outer borders #63

Open
EysseW opened this issue Jun 4, 2022 · 8 comments
Open

Shifted outer borders #63

EysseW opened this issue Jun 4, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@EysseW
Copy link

EysseW commented Jun 4, 2022

So I am fiddling around with shadows ATM, but I wanna shift them. A might be stupid, but I am pretty sure there is no way to shift them, like actual shadows probably would. I would like to see this added.

@EysseW EysseW added the enhancement New feature or request label Jun 4, 2022
@fluix-dev
Copy link
Owner

If by shift you mean have them larger on one side than another, you still have to use a square image but you can have transparent pixels on the opposite side instead of a shadow.

@EysseW
Copy link
Author

EysseW commented Jun 8, 2022

I forgot the reply, I am sorry. No, by shifted I mean as in off center. So it mean the corner has to be shifted as well, and I don't think that is possible at the moment. The corner should thus move with it. It's going to look wonky otherwise. Unfortuneatly, I can't really show what I mean with images since I don't have good reference images.

@EysseW
Copy link
Author

EysseW commented Jun 8, 2022

image

Here's a little example shadow I made with only the right under shadow present. The corners are straight, but I want them to be shifted along with the rest fo the shadow.

@fluix-dev
Copy link
Owner

Ah, I understand. I think what you're trying to achieve may work given some border thickness that could exist at the corners, but if you want just shadow then yes, you would need some offset which doesn't currently exist.

As with many of the other border-related requests, I'm planning on reworking the entire system to use shaders but I'm not sure when I'll get around to getting that fully functional. Alternatively, you can try looking at render_border_textures inside of sway/desktop/render.c too add some offsets and such.

@EysseW
Copy link
Author

EysseW commented Jun 9, 2022

Alright. Thanks!

@EysseW
Copy link
Author

EysseW commented Jun 23, 2022

Looking back at this thread, with that last sentence you were trying to say: "Try coding the thing yourself", right? Or am I missing something here and would it be very easy to fix this myself?

@fluix-dev
Copy link
Owner

"Try coding the thing yourself"

At least for now, yes :)

@EysseW
Copy link
Author

EysseW commented Jun 26, 2022

Totally reasonable, just curious. Thanks for the amazing project man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants