Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow per-window border configuration #24

Open
OdiousImp2604 opened this issue Jan 13, 2021 · 2 comments
Open

Allow per-window border configuration #24

OdiousImp2604 opened this issue Jan 13, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@OdiousImp2604
Copy link

I'm pretty sure there's definitely a way to do this but using the for window [ app id ] etc; then using for example border pixel 1 or border none doesn't remove the image borders.
I tried it without the image border ( on this fork just using normal border) and it worked fine.

sway version 1.5-64ea407f (Dec 18 2020, branch 'master')

for_window [app_id="avizo-service"] floating enable, border none
This removes the border if i'm using normal borders but not when I'm using the images. I'm guessing there's perhaps another variable I should use but it's not documented....

#Borders
gaps inner 28
gaps outer -8
default_border none

border_images.focused ~/.config/sway/borders/focused.png
border_images.focused_inactive ~/.config/sway/borders/focused_inactive.png
border_images.unfocused ~/.config/sway/borders/unfocused.png
border_images.urgent ~/.config/sway/borders/urgent.png

Some relevant part of my config.
2021-01-12T16:52:43,035017360+00:00
If it helps.

@OdiousImp2604 OdiousImp2604 added the bug Something isn't working label Jan 13, 2021
@fluix-dev
Copy link
Owner

I'm hesitant to call this a bug in sway-borders because this is knowingly left out. border_images apply generally to all containers/views and not individually to containers like the standard border pixel.

In this case, avizo shouldn't be asking to have borders drawn in the first place. I don't know much about Wayland, but I believe it should be using the layer-shell protocol, for which Sway won't draw borders for. Most notification daemons, bars, etc. use it.


Overall though, I think it would be great to support per-container border_images, so I'll leave this up as a feature request.

@fluix-dev fluix-dev added enhancement New feature or request and removed bug Something isn't working labels Jan 13, 2021
@OdiousImp2604
Copy link
Author

OdiousImp2604 commented Jan 13, 2021

Oh... sorry. Thank you for the information though!

@fluix-dev fluix-dev changed the title Border Variables Don't Affect The Image Borders Allow per-window border configuration Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants