Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release alpha to NuGet #13

Open
1 of 2 tasks
davidfowl opened this issue Jan 4, 2020 · 4 comments
Open
1 of 2 tasks

Release alpha to NuGet #13

davidfowl opened this issue Jan 4, 2020 · 4 comments

Comments

@davidfowl
Copy link
Collaborator

davidfowl commented Jan 4, 2020

The APIs are almost in a good enough state to get to an alpha. I don't think we need to docs site for that but we should iterate on it to get the APIs more stable. Pushing to nuget should help with getting a broader set of feedback from bleeding edge customers.

Checklist:

@davidfowl
Copy link
Collaborator Author

Now I need to figure out how to have cleaner versions than git version provides for an alpha!

@RobotOptimist
Copy link
Contributor

It's not so bad, you can't use actions/checkout@v1, or at least I haven't been able to get it to work with that, so first things first
in your version.json:

"publicReleaseRefSpec": [
        "^refs/heads/master$"
    ]

this designates that your master branch is the release branch and should not have the -g00fevc stuff appended to the version - although it might be cool to have a designated release branch other than master, i dunno though

next you'll update to actions/checkout@v2 and it will look like this:

    - uses: actions/checkout@v2
      with:
        ref: ${{ github.ref }}
    - run: |
         git fetch --prune --unshallow origin HEAD

if you try to checkout the committing branch using checkout@v1 then git versioning will throw a bunch of errors, using v2 and fetching seems to consistently work

let me know if you'd prefer this via a PR though

@davidfowl
Copy link
Collaborator Author

Here I am again.

@RobotOptimist
Copy link
Contributor

Hi @davidfowl , what's up? If you're ready to do this then I'll submit a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants