Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ TODO #258

Open
4 of 9 tasks
wu-clan opened this issue Dec 20, 2023 · 7 comments
Open
4 of 9 tasks

✨ TODO #258

wu-clan opened this issue Dec 20, 2023 · 7 comments

Comments

@wu-clan
Copy link
Member

wu-clan commented Dec 20, 2023

It would be great if you could provide PR.

We've fully upgraded to Pydantic-V2, but we still have some unfinished business from V1 that we'll continue to push in V2!

  • Dynamic Configuration: Dynamic configuration of the system environment (site title, logo, filing, footer...)
  • code generation [WIP] Add code generator app #318
  • File Upload: Docking cloud OSS and local backup.
  • System Notification: proactively send timed task notifications, resource warnings, service anomaly warnings...

News:

@wu-clan wu-clan pinned this issue Dec 20, 2023
@downdawn
Copy link
Collaborator

Fastapi Upgrade Starlette to >=0.29.0,<0.33.0
https://github.com/tiangolo/fastapi/releases/tag/0.108.0

Sqlmodel will support for Pydantic 2.0
tiangolo/sqlmodel#654

@wu-clan
Copy link
Member Author

wu-clan commented Dec 28, 2023

I got an update push from fastapi but I'm watching https://github.com/encode/starlette/pulls and there are some amazing updates here, if they are merged Fastapi will need to continue to adapt Starlette-1.0.0, will these minor versions continue to be compatible? I'm not sure, but I don't want to consume time for minor versions.

@downdawn
Copy link
Collaborator

These projects share common developers, and we will continue to monitor them.
Our existing project structure is already quite stable, with no significant issues for production.
The current three-tier architecture appears to have room for further optimization, possibly by integrating SQLModel or other methods.

@wu-clan
Copy link
Member Author

wu-clan commented Dec 28, 2023

Our existing project structure is already quite stable, with no significant issues for production.

That's so cool, a solid architecture .

SQLModel is an ORM, we already have SQLA, what are your thoughts?

Repo: here

@downdawn
Copy link
Collaborator

SQLModel is both an SQLAlchemy model and a Pydantic model, so there is a possibility to further merge and simplify 'models' and 'schemas'.

We can keep an eye on this progress:
Migration from SQLAlchemy to SQLModel.
tiangolo/full-stack-fastapi-template#541

@wu-clan
Copy link
Member Author

wu-clan commented Dec 29, 2023

I agree with you, but I'll decline the offer.

Because SQLModel is not updated and fixed at a good pace and is missing documentation, in fact SQLModel was born here: https://github.com/tiangolo/pydantic-sqlalchemy to reduce manual schema definition and validation is great in my opinion;

Although the number of stars for SQLModel is promising, the number of users for it is much lower than for SQLA, and to use SQLModel, the users have to learn it as well,unless SQLModel is really all over the place, I'd migrate to it

@downdawn
Copy link
Collaborator

OK, I agree with you

@wu-clan wu-clan changed the title TODO ✨ TODO Jan 7, 2024
@fastapi-practices fastapi-practices locked as too heated and limited conversation to collaborators Jan 12, 2024
@wu-clan wu-clan removed a link to a pull request Jan 14, 2024
@wu-clan wu-clan linked a pull request Jan 14, 2024 that will close this issue
This was unlinked from pull requests Jan 14, 2024
@fastapi-practices fastapi-practices deleted a comment from nipeone Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants