Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The Linter is blocking otherwise reasonable pull requests #415

Closed
grimley517 opened this issue Apr 30, 2024 · 3 comments
Closed

The Linter is blocking otherwise reasonable pull requests #415

grimley517 opened this issue Apr 30, 2024 · 3 comments
Assignees
@grimley517

Comments

@grimley517
Copy link
Contributor

There are currently a number of PRS in this repository which are failing to build as the linter is blocking them.
@faif
Copy link
Owner

faif commented May 1, 2024

Agreed. Can somebody spend some time on fixing those?

@grimley517 grimley517 mentioned this issue May 8, 2024
Merged
@grimley517
Copy link
Contributor Author

I can't assign myself to this, but PR #417 addresses the issue.

@grimley517 grimley517 mentioned this issue May 13, 2024
Closed
faif added a commit that referenced this issue May 18, 2024
@faif
Merge pull request #417 from grimley517/#415-linter-preventing-prs
81e78fe 
#415 linter preventing prs
@grimley517
Copy link
Contributor Author

This issue is addressed.

Although some doctests still fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grimley517 grimley517

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faif @grimley517