{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":663573391,"defaultBranch":"main","name":"igl","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-07-07T15:57:14.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1717792270.0","currentOid":""},"activityList":{"items":[{"before":"e9a9679a7c06de05cc1db75979488719dc1d0af0","after":"0deeef548072cbae4df88cedf6795a6b250ff11b","ref":"refs/heads/main","pushedAt":"2024-06-08T00:15:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Enable Vulkan Unit Test Infra on FbCode\n\nSummary:\nThis gets us code coverage and lays the foundation for adding Validation Layer\n\nSome tests are disabled for now because they are failing.\n\nReviewed By: EricGriffith, rudybear, corporateshark\n\nDifferential Revision: D58269923\n\nfbshipit-source-id: 772ffc2c73526a2e7b787e98d4466ab8cb4e3c4d","shortMessageHtmlLink":"Enable Vulkan Unit Test Infra on FbCode"}},{"before":"dc13209f4bdd55e9660eac65766846efac986b09","after":null,"ref":"refs/heads/fixup-T191797675-main","pushedAt":"2024-06-07T20:31:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"corporateshark","name":"Sergey Kosarevsky","path":"/corporateshark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2510143?s=80&v=4"}},{"before":"53b59ed229d8929908e08c4cc329c13ca212b683","after":"e9a9679a7c06de05cc1db75979488719dc1d0af0","ref":"refs/heads/main","pushedAt":"2024-06-07T20:31:02.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"corporateshark","name":"Sergey Kosarevsky","path":"/corporateshark","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2510143?s=80&v=4"},"commit":{"message":"Re-sync with internal repository (#122)\n\nThe internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.","shortMessageHtmlLink":"Re-sync with internal repository (#122)"}},{"before":null,"after":"dc13209f4bdd55e9660eac65766846efac986b09","ref":"refs/heads/fixup-T191797675-main","pushedAt":"2024-06-07T19:43:23.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Re-sync with internal repository\n\nThe internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.","shortMessageHtmlLink":"Re-sync with internal repository"}},{"before":"20e03ff048e5321777dc89472d68ff44783a8158","after":"53b59ed229d8929908e08c4cc329c13ca212b683","ref":"refs/heads/main","pushedAt":"2024-06-07T18:31:59.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add test for ivkGetSubpassDescription\n\nSummary: Title\n\nReviewed By: corporateshark\n\nDifferential Revision: D58292418\n\nfbshipit-source-id: 624a1296b7bfdfd4efe23f686d7c6e2763cc2288","shortMessageHtmlLink":"Add test for ivkGetSubpassDescription"}},{"before":"119b048b84339c167a18aa9cab659b95cb6dea6f","after":"20e03ff048e5321777dc89472d68ff44783a8158","ref":"refs/heads/main","pushedAt":"2024-06-07T17:13:48.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Add a new shell app `YUVColorSession`\n\nSummary: Added a new `YUVColorSession` test app - a clone of the `ColorSession` test app.\n\nReviewed By: rudybear\n\nDifferential Revision: D54649237\n\nfbshipit-source-id: 332d500cbf8d84ac13b5bec93502d1abb5ef6df7","shortMessageHtmlLink":"igl | Add a new shell app YUVColorSession"}},{"before":"182b60f2960f72663b2d6337cec091808b62e092","after":"119b048b84339c167a18aa9cab659b95cb6dea6f","ref":"refs/heads/main","pushedAt":"2024-06-07T14:10:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Added file for covering VulkanHelpers.c\n\nSummary: Adding test file to cover `VulkanHelpers.c`\n\nReviewed By: corporateshark\n\nDifferential Revision: D58258194\n\nfbshipit-source-id: 62d6d9efbae7ff43425de50a5e082210497fb855","shortMessageHtmlLink":"Added file for covering VulkanHelpers.c"}},{"before":"65ea35eb2fa8a2cc74c6907e921847b68a7f1da4","after":"182b60f2960f72663b2d6337cec091808b62e092","ref":"refs/heads/main","pushedAt":"2024-06-07T06:22:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | tests | Migrate `RenderCommandEncoder` tests to new drawing functions without `PrimitiveType`\n\nSummary: Migrated all `RenderCommandEncoder` tests to the new IGL drawing functions without `PrimitiveType`.\n\nReviewed By: francoiscoulombe\n\nDifferential Revision: D57995158\n\nfbshipit-source-id: 3d1f0d489e2c11148f72369c02e13b23312181e5","shortMessageHtmlLink":"igl | tests | Migrate RenderCommandEncoder tests to new drawing fun…"}},{"before":"40533b0ee0d291eebabab94c99efbd877cf3a4b3","after":"65ea35eb2fa8a2cc74c6907e921847b68a7f1da4","ref":"refs/heads/main","pushedAt":"2024-06-07T03:53:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"IGLU | Immutable primitive topology in `VertexData`\n\nSummary: Primitive topology is now immutable. Ensure it cannot be changed via `PrimitiveDesc& VertexData::primitiveDesc()` and `PrimitiveDesc::type`.\n\nReviewed By: rudybear, codyly\n\nDifferential Revision: D58204366\n\nfbshipit-source-id: c76a9ff0d38b56916ba3780c47141b76dfbfd21e","shortMessageHtmlLink":"IGLU | Immutable primitive topology in VertexData"}},{"before":"0de20a7c799bd0adc8de498eee29af119a1965f0","after":"40533b0ee0d291eebabab94c99efbd877cf3a4b3","ref":"refs/heads/main","pushedAt":"2024-06-07T00:45:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Don't use old `IRenderCommandEncoder::draw()`\n\nSummary: Don't use the old function `IRenderCommandEncoder::draw()`.\n\nReviewed By: trivedivivek, rameshviswanathan\n\nDifferential Revision: D57891300\n\nfbshipit-source-id: e80bcb968c8fb59313d420de70f9444fa3386ded","shortMessageHtmlLink":"igl | Don't use old IRenderCommandEncoder::draw()"}},{"before":"6d8ff2a4e242c237d902367c4bfd9e2ee7e4be04","after":"0de20a7c799bd0adc8de498eee29af119a1965f0","ref":"refs/heads/main","pushedAt":"2024-06-06T22:16:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"IGLU | Use new `drawIndexed()`\n\nSummary: Use the new IGL API `drawIndexed()`.\n\nReviewed By: rudybear, francoiscoulombe, codyly\n\nDifferential Revision: D58031259\n\nfbshipit-source-id: fa053ca8e62105c24f808461b85df6856f96dc36","shortMessageHtmlLink":"IGLU | Use new drawIndexed()"}},{"before":"b4a034d800aed2ba3f1522aea6d1b5f0920a21ce","after":"6d8ff2a4e242c237d902367c4bfd9e2ee7e4be04","ref":"refs/heads/main","pushedAt":"2024-06-06T21:06:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused header\n\nSummary: Remove unused header from test\n\nReviewed By: pixelperfect3, corporateshark\n\nDifferential Revision: D58251855\n\nfbshipit-source-id: 3a7cacbed5e574e63a59cd7c0a1556b3db7c3d52","shortMessageHtmlLink":"Remove unused header"}},{"before":"0661c13c6baaab53a097259d83928ab4d8cb0863","after":"b4a034d800aed2ba3f1522aea6d1b5f0920a21ce","ref":"refs/heads/main","pushedAt":"2024-06-06T16:52:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add Linux platform for shell session\n\nSummary:\nNOTE: This diff enables linux platform testing for compute which is will be now compatible with running shell session on fbcode\n\nA mirror of the current windows session\n\nReviewed By: kraisler, KyleFung, rudybear, corporateshark\n\nDifferential Revision: D58204984\n\nfbshipit-source-id: d191735fbb315895b43a4e1f464187f6e4e6c13f","shortMessageHtmlLink":"Add Linux platform for shell session"}},{"before":"1642ed8b44e9f5ca31e29a3802284ce64e711065","after":"0661c13c6baaab53a097259d83928ab4d8cb0863","ref":"refs/heads/main","pushedAt":"2024-06-05T21:05:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | vulkan | Fix validation errors in `generateMipmap()`.\n\nSummary:\nFix validation errors in `generateMipmap()`.\n\nIGL has layers/faces and Vulkan has only layers. Handle indexing conversion properly.\n\nReviewed By: EricGriffith, mmaurer\n\nDifferential Revision: D58165615\n\nfbshipit-source-id: 40fcf7acda6f7daf44d62b6a8cd153bc1c9031ba","shortMessageHtmlLink":"igl | vulkan | Fix validation errors in generateMipmap()."}},{"before":"a3724dedd42e5be77c797ede69e8cff32931cdd3","after":"1642ed8b44e9f5ca31e29a3802284ce64e711065","ref":"refs/heads/main","pushedAt":"2024-06-05T19:25:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | tests | Use new `drawIndexed()` function without `PrimitiveType`\n\nSummary: Migrate IGL Tests to use the new `drawIndexed()` function without `PrimitiveType`.\n\nReviewed By: francoiscoulombe\n\nDifferential Revision: D57994599\n\nfbshipit-source-id: 8d949c06f5b31783ffbd2f880adafd6701cf8381","shortMessageHtmlLink":"igl | tests | Use new drawIndexed() function without PrimitiveType"}},{"before":"1fcc39ad3c7e0ac96b4c6b9fd1695f8e4e9dabf8","after":"a3724dedd42e5be77c797ede69e8cff32931cdd3","ref":"refs/heads/main","pushedAt":"2024-06-05T18:47:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | sessions | Use new `IRenderCommandEncoder::drawIndexed()`\n\nSummary: Use the new method `IRenderCommandEncoder::drawIndexed()` in render sessions.\n\nReviewed By: francoiscoulombe\n\nDifferential Revision: D57946830\n\nfbshipit-source-id: ce9439e3acc8d58b960a1b5e7ef0b3240cc0182f","shortMessageHtmlLink":"igl | sessions | Use new IRenderCommandEncoder::drawIndexed()"}},{"before":"e5236b39f55f88ee0e27f5ceed0b12bbfd25d605","after":"1fcc39ad3c7e0ac96b4c6b9fd1695f8e4e9dabf8","ref":"refs/heads/main","pushedAt":"2024-06-05T16:06:18.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add force clearing of swapchain if passthrough is not supported\n\nSummary: Add force clearing of swapchain if passthrough is not supported\n\nReviewed By: corporateshark\n\nDifferential Revision: D58094234\n\nfbshipit-source-id: f16be9183c8a9a99b4453b2906ee8261d031ecf9","shortMessageHtmlLink":"Add force clearing of swapchain if passthrough is not supported"}},{"before":"97f4508a1a506b9d2e78a396c94d928d30b4cc0f","after":"e5236b39f55f88ee0e27f5ceed0b12bbfd25d605","ref":"refs/heads/main","pushedAt":"2024-06-05T14:54:52.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Use new `drawIndexed()` in `Tiny` demos\n\nSummary: Use the new `IRenderCommandEncoder::drawIndexed()` in `Tiny` demos.\n\nReviewed By: trivedivivek, rameshviswanathan\n\nDifferential Revision: D57946829\n\nfbshipit-source-id: 78cddb7b3d5cecb65f05746a96a7a7e76860e5e8","shortMessageHtmlLink":"igl | Use new drawIndexed() in Tiny demos"}},{"before":"dd984928628eda4d97c279a3f05065102cfc3515","after":"97f4508a1a506b9d2e78a396c94d928d30b4cc0f","ref":"refs/heads/main","pushedAt":"2024-06-05T12:05:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | metal | Implement new `IRenderCommandEncoder::draw()`\n\nSummary: Implemented the new function `IRenderCommandEncoder::draw()`.\n\nReviewed By: syeh1, francoiscoulombe\n\nDifferential Revision: D58045915\n\nfbshipit-source-id: b6ea06d3a195abfc1b46950247bb92c85ea9b8c1","shortMessageHtmlLink":"igl | metal | Implement new IRenderCommandEncoder::draw()"}},{"before":"4df7c58ef4aff4d8b619b4ce36d69b3f47b04832","after":"dd984928628eda4d97c279a3f05065102cfc3515","ref":"refs/heads/main","pushedAt":"2024-06-05T08:20:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | vulkan | Implement new `IRenderCommandEncoder::draw()`\n\nSummary: Implemented the new function `IRenderCommandEncoder::draw()`.\n\nReviewed By: syeh1, francoiscoulombe\n\nDifferential Revision: D58045460\n\nfbshipit-source-id: ae6a816a35c701ef8135872f8814a4b3e6bdb415","shortMessageHtmlLink":"igl | vulkan | Implement new IRenderCommandEncoder::draw()"}},{"before":"0b3dacf1294030986584ce453f834be0f8fe1e2f","after":"4df7c58ef4aff4d8b619b4ce36d69b3f47b04832","ref":"refs/heads/main","pushedAt":"2024-06-05T05:54:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Overload `IRenderCommandEncoder::draw()` without `PrimitiveType`\n\nSummary:\nAdded a new overload of `IRenderCommandEncoder::draw()` without `PrimitiveType`.\n\n**P.S.** Per-backend implementations will be added shortly in subsequent diffs.\n\nReviewed By: syeh1, francoiscoulombe\n\nDifferential Revision: D57890499\n\nfbshipit-source-id: e58fab2ada55f4a4614950523310b697a2f31a0c","shortMessageHtmlLink":"igl | Overload IRenderCommandEncoder::draw() without PrimitiveType"}},{"before":"3f8d3dfcaeacb3a541a8bc58a868d672ff89d035","after":"0b3dacf1294030986584ce453f834be0f8fe1e2f","ref":"refs/heads/main","pushedAt":"2024-06-04T21:21:22.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Support for multiple preferred swapchain formats\n\nSummary: Some desktop configurations do not support VK_FORMAT_D24_UNORM_S8_UINT (e.g. it happens in Monado Simulator for Windows). This diff allows us to define list of preferred formats\n\nReviewed By: corporateshark\n\nDifferential Revision: D58108748\n\nfbshipit-source-id: ab18a0487cfaf3c49d451e2f2adaeed127bcc85e","shortMessageHtmlLink":"Support for multiple preferred swapchain formats"}},{"before":"a0026fee0c612d87a97c05bb2adfca6c3f2e720d","after":"3f8d3dfcaeacb3a541a8bc58a868d672ff89d035","ref":"refs/heads/main","pushedAt":"2024-06-04T13:44:32.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Improve HW device selection for Vulkan\n\nSummary: Check what HW device was selected by OpenXR\n\nReviewed By: maliarov\n\nDifferential Revision: D58082109\n\nfbshipit-source-id: 2c065059a6d3a674c87011bea326cd96cb739ccd","shortMessageHtmlLink":"Improve HW device selection for Vulkan"}},{"before":"48cfea1dc2149e38477b521e8ca87f7756993681","after":"a0026fee0c612d87a97c05bb2adfca6c3f2e720d","ref":"refs/heads/main","pushedAt":"2024-06-03T08:40:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Backport fix from KTX main branch\n\nSummary:\nThis is the same fix as in https://github.com/KhronosGroup/KTX-Software/blob/main/lib/texture2.c#L252\n\nAdditionaly Ktx2TextureLoaderTest has a bug where `DfdByteLength` was equla to 48, while the whole Dfd packet was only 44. This filed should be equal exactly to the size of Dfd packet: https://www.internalfb.com/code/fbsource/[ed4a48125e24]/arvr/third-party/ktx-software/ktx-software/lib/dfdutils/createdfd.c?lines=34\n\nReviewed By: syeh1\n\nDifferential Revision: D57830644\n\nfbshipit-source-id: 72ad92efd17f1da566ca8a94121d051e66f9328a","shortMessageHtmlLink":"Backport fix from KTX main branch"}},{"before":"261c151ebb54456caf45d3fee9a3a79b840fd92f","after":"48cfea1dc2149e38477b521e8ca87f7756993681","ref":"refs/heads/main","pushedAt":"2024-06-01T00:49:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"IGL: Fix Vulkan mipmap generation for cubemaps\n\nSummary: This diff fixes Vulkan mipmap generation for cubemaps.\n\nReviewed By: pixelperfect3, corporateshark\n\nDifferential Revision: D57894232\n\nfbshipit-source-id: b95d74d022aa479a6a7e37ff4b0f96ff05ce0007","shortMessageHtmlLink":"IGL: Fix Vulkan mipmap generation for cubemaps"}},{"before":"c6169d32612a0c4ff90ecab6a0c14b782e77e6f2","after":"261c151ebb54456caf45d3fee9a3a79b840fd92f","ref":"refs/heads/main","pushedAt":"2024-05-31T23:46:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use the viewport scale to set the target size.\n\nSummary: This passes the viewport scale into the Xru Context to set the render target size.\n\nReviewed By: mriegger\n\nDifferential Revision: D58001263\n\nfbshipit-source-id: 30aa6f18af36cb1d8c0617667c1dbf9f9ab9ea21","shortMessageHtmlLink":"Use the viewport scale to set the target size."}},{"before":"a104a63a16ee292fd19cbbef8ca330139c613ab8","after":"c6169d32612a0c4ff90ecab6a0c14b782e77e6f2","ref":"refs/heads/main","pushedAt":"2024-05-31T21:03:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove incorrect collision check\n\nSummary:\nThis check doesn't make sense, consider the following sequence of calls:\n```\n// drawing the first object\nencoder.bindBuffer (0, bufferA)\nencoder.bindVertexBuffer(1, bufferB)\nencoder.draw(...)\n\n// drawing a different object\nencoder.bindBuffer (1, bufferC)\nencoder.bindVertexBuffer(0, bufferD)\nencoder.draw(...)\n```\nThis is perfectly valid (and will work correctly), but this check here determines this to be a collision.\n\nThere is an effect 778223544407551 which issues commands using this pattern and which crashes on IOS due to this check.\n\nReviewed By: EricGriffith, KyleFung, corporateshark\n\nDifferential Revision: D58029138\n\nfbshipit-source-id: 7f266cc965f9e63f6414d527ecdeea5aa063e1a0","shortMessageHtmlLink":"Remove incorrect collision check"}},{"before":"f381f2358aeab9ac496d46174fed0a50003ecb24","after":"a104a63a16ee292fd19cbbef8ca330139c613ab8","ref":"refs/heads/main","pushedAt":"2024-05-31T14:18:36.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Refactor swapchain providers\n\nSummary: Pass image width and height to the swapchain providers instead of `XrViewConfigurationView`, quad layers do not obligatory have sizes equal to XR viewport sizes\n\nReviewed By: EricGriffith\n\nDifferential Revision: D58013263\n\nfbshipit-source-id: a2972fd6eab9235eaee77b661f06c92d108fb950","shortMessageHtmlLink":"Refactor swapchain providers"}},{"before":"d3e0e3d44c2e4c965d83dff83bddd88b2670b874","after":"f381f2358aeab9ac496d46174fed0a50003ecb24","ref":"refs/heads/main","pushedAt":"2024-05-31T13:20:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"22/t - Export AHardwareBuffer from the IGL OpenGL Texture\n\nSummary:\n# This stack\n\nD57825400\n\nSeveral diffs follow to get app side Bitmap creates with a IGL/C++ side hardware texture backing.\n\nThis relies on API level 29 (Hardware buffer stuff was API level 26), and\n* the Bitmap.wrapHardwareBuffer call, which needs a\n* app side HardwareBuffer, which can be obtained from the C++ side via\n* AHardwareBuffer_toHardwareBuffer JNI, but this needs\n* the pointer to the underlying AHardwareBuffer, which is hidden inside\n* the IGL NativeHWBuffer.h class\n\nThe next several diffs walk this information up from the C++ piece, converting and wrapping items as needed.\n\n# This diff\n\nmake the `AHardwareBuffer` public\n\nReviewed By: codyly\n\nDifferential Revision: D57861811\n\nfbshipit-source-id: 558ba2ede202472a066e899298f2c61fd32c2872","shortMessageHtmlLink":"22/t - Export AHardwareBuffer from the IGL OpenGL Texture"}},{"before":"15515bc6dc6675b5a4c8b4f9dfce92a234435b8d","after":"d3e0e3d44c2e4c965d83dff83bddd88b2670b874","ref":"refs/heads/main","pushedAt":"2024-05-31T05:22:03.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"igl | Remove old `multiDrawIndexedIndirect()`\n\nSummary: Removed unused code.\n\nReviewed By: EricGriffith, syeh1, rudybear\n\nDifferential Revision: D57807344\n\nfbshipit-source-id: d9d79ef7bbb97a84ef7e6e3dd1d1c1360c277b7e","shortMessageHtmlLink":"igl | Remove old multiDrawIndexedIndirect()"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEX60rMQA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/igl"}