-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ds2482-800 #2693
Comments
Post a link |
This is the code. Il that OK ? |
Excuse me but I'm really bad at git. I closed this request by mistake. |
@alainstark We need a doc description too, could you make it? |
Yes, is this link the right thing to learn ? |
First of all: thank you!!! I tried this out, it works me only with "index", not working (no temperature data) if i use the sensor "address" (without index) - my settings: external_components:
ds248x: sensor:
What is wrong with it? Can you help me? |
Have you incrase the verbosity of the logs ? |
I belive that you should not use id: ds2482_800_ch1_1. This syntax is for multiple ds248x on the same I²C bus. Comment this line and test again. |
And this is the doc :-) |
Thank you very much! It's work! :) I don't know why, but there were some indentation problem in the sensor.py file (i unziped and opened it from Linux, Geany and Kate): After unzip:
After orrection:
I will change the id sytax. I am very gateful for your help and this code and documentation! (Sorry, my English is not very good...) |
Yes it's my fault. Before generating the zip archive, I opened the code in emacs and mechanically indented the code without testing. |
Less pro, but can be done even from web UI of GitHub. |
I'd like to help, but unfortunately i don't know git at all (basically, i work with hardware), i hope you can somehow get it together with ESPHome Repo! (I'll write as soon as i find someone who could help.) I think it absolutely fills a gap! |
Ok nagyrobi. I used the non pro method. |
Now you see in your esphome repo, at the top of the page a link "This branch is 5 commits ahead of". Click on "5 commits ahead of" and make the pull request. Make sure you complete the exact instructions. For the docs similar, but please make sure that in the Comparing changes window you correct manually the "Base repository" base to be "next" not "current" !! Whet you're done, you can look at your PR and edit the first post to add the required PR links to connect the two to each-other. |
Great! |
Okay, I think I'm almost there. I still have a problem with updating CODEOWNERS. I wait for the approwing review. |
You can safely put yourself as codeowner because the goal is to have the system notify somebody if the component needs some changes in the future, that's all. |
Ok I have do it. |
I think I didn't do the right thing regarding |
Maybe the script is broken. Let your codeowners in, I removed the label manually. |
Ok I added the line again that give me an error in script/ci-custom :
|
It's fine |
Hello, |
Just wait patiently from now... |
Hello, I have write code to support ds2482-800 to the component ds248x
I have comment this feature at the end of this feature-request
I am not a git expert, can you help me to add the ds248x component to esphome ?
The text was updated successfully, but these errors were encountered: