Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

//test/integration/python:hotrestart_handoff_test flakes and misleads #34147

Open
ravenblackx opened this issue May 14, 2024 · 0 comments
Open

//test/integration/python:hotrestart_handoff_test flakes and misleads #34147

ravenblackx opened this issue May 14, 2024 · 0 comments
Assignees
@ravenblackx
Labels
area/test flakes

Comments

@ravenblackx
Copy link
Contributor

https://dev.azure.com/cncf/envoy/_build/results?buildId=170420&view=logs&j=767be981-567e-57d8-68c3-2140ede0a0bd&t=2181edf2-f610-59f2-c43a-04bb9d0bca00&l=1401

Two-part failure, first new requests after hot restart begins should go to new cluster then test_dead_parent_startup fails to start the first instance, because the previous failed test didn't terminate its process.

So two-part fix, making the test clean up better if it fails, and making it not fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ravenblackx ravenblackx

Labels
area/test flakes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ravenblackx