-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple executionContext/create
messages prevent app startup
#9993
Comments
I don't see any issues in nightly from 14/05 (no nightiles between 14th and 17th, so can't triage that one easily). |
executionContext/create
prevent app startupexecutionContext/create
messages prevent app startup
It appears to be only(?) reproducible for less powerful machines. Still, I think we should discuss retries that GUI is making as some of the sent messages are not idempotent. |
I'm aware of the problem with retries, but honestly I haven't expected we hit it so early :) Technically, on problems like "timeout" we have no idea what is the engine's state. One solution would be marking the execution context as "broken" and try to destroy it and recreate on every single failure in its creation or frame change. Perhaps visualization as well? To avoid unnecessary visualizations nobody listens to. Here the problem is, that even slight connectivity issue would destroy all caches. So better solution would be to have an ability to read the current engine's state. Then, after a timeout, we could read the state first to check if last call was actually applied or not. But that requires adding new methods to engine. |
Are you sure something wasn't broken recently? I built my own nightlies and narrowed it down to somewhere between 14th and 15th, i.e. 52b8ed4...c437721. |
I'm afraid I narrowed it down to your commit, @vitvakatu, 52b8ed4. It's weird though, it looks innocent. |
Let's also see if it gets fixed by #9951 as it fixes the same project being initialized twice. |
Discord username
No response
What type of issue is this?
Permanent – Occurring repeatably
Is this issue blocking you from using Enso?
Is this a regression?
What issue are you facing?
Somewhere between 08/05 and 17/05 a regression was introduced that leads to multiple
executionContext/create
requests being sent by GUI when creating a new project (likely also when opening an existing project).See screenshot.
Expected behaviour
No failures on startup on a hello world example.
How we can reproduce it?
Try to open a new project with latest nightly.
Screenshots or screencasts
Logs
Enso Version
17/05 nightly
Browser or standalone distribution
Standalone distribution (local project)
Browser Version or standalone distribution
standalone
Operating System
Linux
Operating System Version
No response
Hardware you are using
No response
The text was updated successfully, but these errors were encountered: