Generalize keyed local storage for more client side graph-editor data #9990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frizi
added
CI: No changelog needed
farmaazon
approved these changes
May 20, 2024
Comment on lines
84
to
86
| s: number | ||
| doc: boolean | ||
| rw: number | null |
There was a problem hiding this comment.
Why we're so cryptic? RW sounds like "Read-Write" :)
| @@ -0,0 +1,142 @@ | |||
| import { useAbortScope } from '@/util/net' | |||
| import { debouncedWatch, useLocalStorage } from '@vueuse/core' | |||
There was a problem hiding this comment.
I didn't know there is something like debounceWatch. You may check if it's suitable to our debouncedGetter (my implementation uses timeouts).
There was a problem hiding this comment.
Yes, I think is actually a suitable and easy to understand replacement for manual timers in this case. I'm going to refactor it then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes #9938
The documentation panel openness and size state are saved in localStorage. On initial graph entry, the documentation panel is automatically opened if the graph's function is documented.
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.