Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue about delivery.dropped hook and metric #12607

Open
tigercl opened this issue Feb 28, 2024 · 0 comments
Open

Issue about delivery.dropped hook and metric #12607

tigercl opened this issue Feb 28, 2024 · 0 comments
Assignees

Comments

@tigercl
Copy link
Member

tigercl commented Feb 28, 2024

What happened?

Issue 1

The delivery.dropped hook is not called when the delivery.dropped.too_large count is incremented.

Issue 2

The definition of message.delivered is the number of messages forwarded to subscribers internally in EMQX.

The definition of these metrics: delivery.dropped.expired, delivery.dropped.no_local, is the number of messages dropped before being actually sent to the physical subscriber after being forwarded to the subscriber process.

But now the growth of these metrics such as delivery.dropped.expired occurs before message.delivered, and only delivery.dropped.too_large occurs after message.delivered. This is inconsistent with the definition.

What did you expect to happen?

  1. Call delivery.dropped hook when the delivery.dropped.too_large count is incremented.
  2. All increments of delivery.dropped.* metrics should be placed after message.delivered

How can we reproduce it (as minimally and precisely as possible)?

No response

Anything else we need to know?

No response

EMQX version

EMQX v5.4.1

OS version

macOS 13.4

Log files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants