Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: setBrowserView broken in v30 on macOS, works on Windows #42202

Open
3 tasks done
Stanzilla opened this issue May 16, 2024 · 4 comments
Open
3 tasks done

[Bug]: setBrowserView broken in v30 on macOS, works on Windows #42202

Stanzilla opened this issue May 16, 2024 · 4 comments

Comments

@Stanzilla
Copy link

Stanzilla commented May 16, 2024

Preflight Checklist

Electron Version

30.0.6

What operating system are you using?

macOS

Operating System Version

14.5

What arch are you using?

arm64 (including Apple Silicon)

Last Known Working Electron version

29

Expected Behavior

Same functionality as in v29

Actual Behavior

When this line of code if present, the app will only show a blank window:

mainWindow.setBrowserView(ads);

ads is defined as follows:

ads = new BrowserView({
    webPreferences: {
      partition: 'persist:adpartition',
    },
  });

On Windows everything works as before in v29.

Testcase Gist URL

No response

Additional Information

No response

@electron-issue-triage
Copy link

Hello @Stanzilla. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro Needs a test case to reproduce the bug label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

@Stanzilla
Copy link
Author

Stanzilla commented May 16, 2024

Hello @Stanzilla. Thanks for reporting this and helping to make Electron better!

Would it be possible for you to make a standalone testcase with only the code necessary to reproduce the issue? For example, Electron Fiddle is a great tool for making small test cases and makes it easy to publish your test case to a gist that Electron maintainers can use.

Stand-alone test cases make fixing issues go more smoothly: it ensure everyone's looking at the same issue, it removes all unnecessary variables from the equation, and it can also provide the basis for automated regression tests.

Now adding the blocked/need-repro Needs a test case to reproduce the bug label for this reason. After you make a test case, please link to it in a followup comment. This issue will be closed in 10 days if the above is not addressed.

Here is the Fiddle https://gist.github.com/Stanzilla/be0c9e14572178e6b3a9b2237a486074 - it is possible that this is an issue with stateful-electron-window if yes, I will create an issue over there.

@electron-issue-triage electron-issue-triage bot removed the blocked/need-repro Needs a test case to reproduce the bug label May 16, 2024
@codebytere
Copy link
Member

Looks like it's related to #41256 being in 30 and not #41326

@codebytere codebytere added status/confirmed A maintainer reproduced the bug or agreed with the feature component/WebContentsView labels May 17, 2024
@Stanzilla
Copy link
Author

Looks like it's related to #41256 being in 30 and not #41326

Does that mean it should be fixed in 31?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 Unsorted Items
Development

No branches or pull requests

2 participants