Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[canvas] Canvas API should implement HasAppContext interface #183672

Closed
nreese opened this issue May 16, 2024 · 1 comment · Fixed by #183744
Closed

[canvas] Canvas API should implement HasAppContext interface #183672

nreese opened this issue May 16, 2024 · 1 comment · Fixed by #183744
Assignees
@nreese
Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
Canvas

Comments

@nreese
Copy link
Contributor

nreese commented May 16, 2024 •
edited

Canvas provides getAppContext when rendering legacy embeddables.

Canvas should also provide getAppContext when rendering react embeddables
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Feature:Canvas project:embeddableRebuild labels May 16, 2024
@kibanamachine kibanamachine added loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels May 16, 2024
@kibanamachine kibanamachine added this to Inbox in Canvas May 16, 2024
@nreese nreese self-assigned this May 16, 2024
@nreese
Copy link
Contributor Author

nreese commented May 16, 2024

Blocking #178158

@nreese nreese mentioned this issue May 17, 2024
Merged
nreese added a commit that referenced this issue May 17, 2024
@nreese @kibanamachine
[canvas] fix Canvas API should implement HasAppContext interface (#18…
82044e1 
…3744)

Closes #183672

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nreese nreese

Labels
bug Fixes for quality problems that affect the customer experience Feature:Canvas impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
No open projects
Canvas
  
Inbox
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[canvas] fix Canvas API should implement HasAppContext interface nreese/kibana
2 participants
@nreese @kibanamachine