Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix thread reinitialize in time-series source operator #108751

Merged
merged 1 commit into from
May 17, 2024
Merged

Fix thread reinitialize in time-series source operator #108751

merged 1 commit into from
May 17, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented May 17, 2024 •
edited

Currently, we only reinitialize the Lucene internal of the new top if the tsid changes. This isn't enough. We should always ensure the new top is reinitialized if necessary, regardless of tsid.

Closes #108727

@dnhatn dnhatn requested a review from martijnvg May 17, 2024 05:36
@dnhatn dnhatn marked this pull request as ready for review May 17, 2024 05:36
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn
Copy link
Member Author

dnhatn commented May 17, 2024

run elasticsearch-ci/part-2

martijnvg
martijnvg approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dnhatn
Copy link
Member Author

dnhatn commented May 17, 2024

Thanks Martijn!

@dnhatn dnhatn merged commit a2ab2fe into elastic:main May 17, 2024
10 of 15 checks passed
@dnhatn dnhatn deleted the fix-time-series-source branch May 17, 2024 15:24
@dnhatn dnhatn added auto-backport-and-merge Automatically create backport pull requests and merge when ready backport pending and removed auto-backport-and-merge Automatically create backport pull requests and merge when ready labels May 17, 2024
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request May 19, 2024
@dnhatn
Fix thread reinitialize in time-series source operator (elastic#108751)
0ac68c1 
Currently, we only reinitialize the Lucene internal of the new top if 
the tsid changes. This isn't enough. We should always ensure the new top
is reinitialized if necessary, regardless of tsid.

Closes elastic#108727
@dnhatn dnhatn mentioned this pull request May 19, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request May 19, 2024
@dnhatn
Fix thread reinitialize in time-series source operator (#108751) (#10…
93f6b31 
…8813)

Currently, we only reinitialize the Lucene internal of the new top if 
the tsid changes. This isn't enough. We should always ensure the new top
is reinitialized if necessary, regardless of tsid.

Closes #108727
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg approved these changes

Assignees
No one assigned
Labels
>non-issue :StorageEngine/Metrics You know, for Metrics Team:StorageEngine v8.14.1 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] TimeSeriesSortedSourceOperatorTests testRandom failing
3 participants
@dnhatn @elasticsearchmachine @martijnvg