Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI notebook failures possibly due to new Langchain integration #240

Closed
miguelgrinberg opened this issue May 16, 2024 · 2 comments · Fixed by #242
Closed

CI notebook failures possibly due to new Langchain integration #240

miguelgrinberg opened this issue May 16, 2024 · 2 comments · Fixed by #242

Comments

@miguelgrinberg
Copy link
Collaborator

miguelgrinberg commented May 16, 2024 •
edited

There are two tests from our CI that are now failing, presumably after they started using the updated langchain integration.

The errors:

Running notebooks/document-chunking/with-langchain-splitters.ipynb... Failed
...
BadRequestError: BadRequestError(400, 'x_content_parse_exception', "[1:117] [text_embedding] model_id doesn't support values of type: VALUE_NULL")

Running notebooks/langchain/langchain-using-own-model.ipynb... Failed
...
AttributeError: 'ElasticsearchStore' object has no attribute 'client'

@maxjakob any ideas?

Complete run with these failures: https://github.com/elastic/elasticsearch-labs/actions/runs/9113170450
@maxjakob
Copy link
Contributor

maxjakob commented May 16, 2024 •
edited

Great that we have these tests. I should not have removed the client attribute. This PR brings it back and fixes the second issue:
langchain-ai/langchain-elastic#29

@maxjakob
Copy link
Contributor

maxjakob commented May 16, 2024 •
edited

For the first thing model_id doesn't support values of type: VALUE_NULL: the new version of langchain-elasticsearch does not have a default value for sparse vector models any more (used to be .elser_model_2) because it caused some issues with inconsistent cluster states.

EDIT: the notebook in question extends a class that is now deprecated in 0.2.0 and extending it is not supported anymore.

maxjakob added a commit that referenced this issue May 17, 2024
@maxjakob
Splitter notebook: extend new strategy class
0a3df6e 
fixes #240
@maxjakob maxjakob mentioned this issue May 17, 2024
Merged
maxjakob added a commit that referenced this issue May 17, 2024
@maxjakob
Splitter notebook: extend new strategy class (#242)
f8bb1aa 
* Splitter notebook: extend new strategy class

fixes #240

* remove variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Splitter notebook: extend new strategy class elastic/elasticsearch-labs
2 participants
@maxjakob @miguelgrinberg