Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy fields Protocol, Host, Path from Config struct in internal/pkg/remote/config.go #4771

Open
pchila opened this issue May 16, 2024 · 2 comments
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@pchila
Copy link
Contributor

pchila commented May 16, 2024

remote.Config struct contains fields Protocol, Host, Path that are initialized from the enroll command using the --url CLI option.
Fleet sends connection parameters in policy change action only using Hosts as a []string containing full URLs without splitting them into URL parts.

The goal of this issue is to refactor the enroll command to use the same field as we receive in the policy change action and remove the legacy fields to reduce the noise about fleet client configuration.

@pchila pchila added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team labels May 16, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

2 participants