Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: tests/test_service_cli.py::test_shutdown_called_on_shutdown_signal[Signals.SIGINT] #2517

Open
artem-shelkovnikov opened this issue May 8, 2024 · 1 comment · May be fixed by #2539
Labels
bug Something isn't working

Comments

@artem-shelkovnikov
Copy link
Member

One unit test is flaky and from time to time takes too much time to run, causing CI to terminate the process:
bin/pytest tests/test_service_cli.py::test_shutdown_called_on_shutdown_signal

@artem-shelkovnikov artem-shelkovnikov added the bug Something isn't working label May 8, 2024
@artem-shelkovnikov artem-shelkovnikov linked a pull request May 9, 2024 that will close this issue
8 tasks
@artem-shelkovnikov artem-shelkovnikov changed the title Flaky test: tests/test_service_cli.py::test_shutdown_called_on_shutdown_signal[Signals.SIGTERM] Flaky test: tests/test_service_cli.py::test_shutdown_called_on_shutdown_signal[Signals.SIGINT] May 13, 2024
@artem-shelkovnikov
Copy link
Member Author

Tried looking into it and it's really weird, feels like it's an interrupt that happens in a wrong moment.

Testing it a bit locally showed that the test does not interrupt because some services (in my case it was job cleanup service) did not exit.

I think it happens because SIGINT/SIGTERM happens in between service startup - e.g. Job Scheduling/Job Execution Services has just started, next Job Cleanup Service will attempt to start, but interrupt happens before and service just starts.

☝️ This info is just a theory, I was unable to prove or discard it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant