Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github swallows errors even if fetching issues fails #2395

Open
3 tasks
Tracked by #2393
seanstory opened this issue Apr 16, 2024 · 0 comments
Open
3 tasks
Tracked by #2393

github swallows errors even if fetching issues fails #2395

seanstory opened this issue Apr 16, 2024 · 0 comments

Comments

@seanstory
Copy link
Member

seanstory commented Apr 16, 2024

part of #2393

Description

The github connector is currently just logging a warning instead of propagating an error, if something goes wrong while fetching issues. See:

except Exception as exception:
self._logger.warning(
f"Something went wrong while fetching the repository. Exception: {exception}",
exc_info=True,
)

This error should probably be re-raised if it's not something that can be re-tried. If the github connector cannot sync any issues at all, the sync should fail. If it's just a single issue or two, that's probably ok for a WARN message.

Acceptance Criteria

  • github connector fails syncs if no issues can be synced
  • github connector attempts retries for errors that look transient
  • errors with limited scope (single documents, or edge cases) can be moved past with sufficient WARN logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants