Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Oracle connector to support service name #2429

Merged
merged 4 commits into from
May 2, 2024
Merged

Update Oracle connector to support service name #2429

merged 4 commits into from
May 2, 2024

Conversation

parth-elastic
Copy link
Collaborator

Closes #2382

Added the new RCF for connecting to Oracle with Service name.

Checklists

Pre-Review Checklist

  • this PR does NOT contain credentials of any kind, such as API keys or username/passwords (double check config.yml.example)
  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Tested the changes locally
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes
  • Contributed any configuration settings changes to the configuration reference
  • if you added or changed Rich Configurable Fields for a Native Connector, you made a corresponding PR in Kibana

@parth-elastic parth-elastic requested a review from a team as a code owner April 24, 2024 08:14
artem-shelkovnikov
artem-shelkovnikov reviewed Apr 30, 2024
View reviewed changes
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just in case, have you checked that this change is forwards-compatible? E.g. having a working connector with old configurable fields will not break the connector once this change is applied?

@parth-elastic
Copy link
Collaborator Author

Yes, verified that this change maintains forwards compatibility. The new configuration will seamlessly integrate with existing connectors, ensuring they remain operational after the update. The previous configuration, known as the SID database, will continue to function properly. However, there is an update: if the service_name is selected, the DSN will now be the service name instead of the SID.
image (5)

@moxarth-elastic moxarth-elastic enabled auto-merge (squash) May 2, 2024 10:16
@moxarth-elastic moxarth-elastic merged commit 33f48ed into main May 2, 2024
2 checks passed
@moxarth-elastic moxarth-elastic deleted the enhancement/oracle-update-service-name branch May 2, 2024 10:21
@github-actions GitHub Actions
Copy link

github-actions bot commented May 2, 2024

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2429 --autoMerge --autoMergeMethod squash

@leemthompo
Copy link
Contributor

Docs PR: https://github.com/elastic/enterprise-search-pubs/pull/4415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artem-shelkovnikov artem-shelkovnikov artem-shelkovnikov approved these changes

Assignees
No one assigned
Labels
auto-backport v8.15.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Oracle connector is using obsolete SID in connection string
5 participants
@parth-elastic @leemthompo @artem-shelkovnikov @moxarth-elastic @praveen-elastic