Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send APMConfig to registered apm reloaders when the config has changed #39606

Open
ycombinator opened this issue May 16, 2024 · 1 comment
Open
Assignees
Labels
enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@ycombinator
Copy link
Contributor

Describe the enhancement:

Taken from elastic/apm-server#11381:

The client.Expected struct attached to each unit contains an APMConfig field:

type Expected struct {
	Config    *proto.UnitExpectedConfig
	Features  *proto.Features
	LogLevel  UnitLogLevel
	State     UnitState
	APMConfig *proto.APMConfig
}

When this field's value changes, the change is signaled using TriggeredAPMChange

	// TriggeredAPMChange indicates that the APM configuration has changed
	// This constant represents a single bit in a bitmask
	TriggeredAPMChange // apm_config_change_triggered

We should detect this change and send the changed APMConfig to all reloaders registered under a new libbeat/common/reload registry key, "apm".

See also elastic/apm-server#11381 (comment), elastic/apm-server#11381 (comment), and other comments in that issue for more context / background.

Describe a specific use case for the enhancement or feature:

elastic/apm-server#11381

@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

3 participants