Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing name for attach without mapParams/source #1000

Open
NazariiShvets opened this issue Oct 23, 2023 · 0 comments · May be fixed by #1058
Open

Allow passing name for attach without mapParams/source #1000

NazariiShvets opened this issue Oct 23, 2023 · 0 comments · May be fixed by #1058
Labels
good first issue Good for newcomers typings Typescript public type definitions issues

Comments

@NazariiShvets
Copy link

NazariiShvets commented Oct 23, 2023 •
edited by sergeysova

Missing/Incorrect APIs

Can't pass name paramether in attach without mapParams/source

Suggested Implementation

effector/packages/effector/index.d.ts

Line 2744 in 9d0f59a

effect: FX

Current:

export function attach<
  FX extends Effect<any, any, any>,
>(config: {
  effect: FX
}): Effect<EffectParams<FX>, EffectResult<FX>, EffectError<FX>>

New:

export function attach<
  FX extends Effect<any, any, any>,
>(config: {
  effect: FX,
  name?: string;
}): Effect<EffectParams<FX>, EffectResult<FX>, EffectError<FX>>
@NazariiShvets NazariiShvets added the typings Typescript public type definitions issues label Oct 23, 2023
@zerobias zerobias added the good first issue Good for newcomers label Oct 23, 2023
@kireevmp kireevmp linked a pull request Mar 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers typings Typescript public type definitions issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow name in attach when only passing effect kireevmp/effector
2 participants
@zerobias @NazariiShvets