Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allSettled should not accept derived units #1039

Open
zerobias opened this issue Jan 11, 2024 · 1 comment
Open

allSettled should not accept derived units #1039

zerobias opened this issue Jan 11, 2024 · 1 comment
Labels
bug Something isn't working fork api

Comments

@zerobias
Copy link
Member

This code should throw runtime error and show error in typings:

const scope = fork()
const foo = createEvent()
const bar = foo.map(x => x)

allSettled(bar, {params: 1, scope})
const scope = fork()
const $foo = createStore(0)
const $bar = combine($foo, x => x)

allSettled($bar, {params: 1, scope})
@zerobias zerobias added bug Something isn't working good first issue Good for newcomers fork api and removed good first issue Good for newcomers labels Jan 11, 2024
@zerobias
Copy link
Member Author

There is another issue: Gate.open in effector-react, there are a lot of tests which triggers open with allSettled, so it should be converted to EventCallable before releasing an update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fork api
Projects
None yet
Development

No branches or pull requests

1 participant