[vscode] Add WindowState active in plugin API #13718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
reviewed
May 27, 2024
packages/plugin-ext/src/main/browser/window-activity-tracker.ts
Outdated
Show resolved
Hide resolved
packages/plugin-ext/src/main/browser/window-activity-tracker.ts
Outdated
Show resolved
Hide resolved
|
Thanks for your review, @msujew ! |
msujew
approved these changes
May 28, 2024
packages/plugin-ext/src/main/browser/window-activity-tracker.ts
Outdated
Show resolved
Hide resolved
fixes eclipse-theia#13692 contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <rschnekenburger@eclipsesource.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Implements the new VS Code API WindowState Active
Fixes #13692
Contributed on behalf of ST Microelectronics
How to test
This can be tested with the following extension:
This extension will display a notification has soon as window state is changed, focus or active. To test, you can get or lose focus with any combination of idle time to check activity state. User is considered as inactive after 20sec of doing nothing, and this timer will be reset has soon as a mouse button is clicked / key stroke or touch gesture.
Follow-ups
None
Review checklist
Reminder for reviewers