Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MSI #5192

Closed
kenkendk opened this issue May 16, 2024 · 2 comments · Fixed by #5203
Closed

Improve MSI #5192

kenkendk opened this issue May 16, 2024 · 2 comments · Fixed by #5203

Comments

@kenkendk
Copy link
Member

The current MSI UI is non-existing and this makes it impossible to toggle various features.
There is some support in wixl that supports UIs, so hopefully there is enough to get at least on-par:
https://gitlab.gnome.org/GNOME/msitools/-/merge_requests/30

@ts678
Copy link
Collaborator

ts678 commented May 17, 2024

Maybe not impossible, as I did it the ugly way. I'm not looking at the merge request closely, but I notice it's not merged.
If this issue can't be closed, possibly a manual workaround can be documented for dealing with the start at login feature.

I am not a lawyer, and I don't know the risk level from not showing a click-through license. Mainly worried about liability.
MIT license is linked from the About page of the GUI, but is that enough? I can't immediately find it in CommandLine.exe
licenses\license.txt exists, but doesn't show the copyright holder.

@kenkendk
Copy link
Member Author

I managed to get a working WixUI_FeatureTree UI sequence up with wixl so now we are on-par with the previous installers. It is also in a state that we can work new feature in as needed later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants