Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu 1.12: helper functions are deprecated #7847

Open
4 tasks done
lzmartinico opened this issue Apr 25, 2024 · 2 comments
Open
4 tasks done

mu 1.12: helper functions are deprecated #7847

lzmartinico opened this issue Apr 25, 2024 · 2 comments
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet

Comments

@lzmartinico
Copy link

lzmartinico commented Apr 25, 2024

I confirm that...

  • I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.

  • I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.

  • The issue can be reproduced on the latest available commit of Doom.

  • The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. (Unstable versions end in .50, .60, or .9x)

Expected behavior

mu4e deprecated helper function mu4e--view-gather-mime-parts. As a consequence, the commands defined in doom's module +mu4e-view-select-mime-part-action and +mu4e-view-open-attachment no longer work.

Current behavior

When one of the two commands above is invoked in mu4e-view mode, message ’mu4e-view--mime-parts’ elisp declaration not found. is triggered.
I suspect +mu4e-view-select-mime-part-action could be seamlessly replaced with mu4e-view-mime-part-action. I couldn't find an adequate alternative for +mu4e-view-open-attachment, and while mu4e-view-mime-parts seems to be the designated replacement function, it's not quite a drop-in replacement

Steps to reproduce

  1. Open mu4e
  2. select any email with attachments
  3. press A or o

System Information

N/A, Emacs 29.3 on latest commit

@lzmartinico lzmartinico added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Apr 25, 2024
@alarawms
Copy link

alarawms commented May 6, 2024

I had a way to overcome this temporary.

Disable the mu4e module in doom, and load the path within the config.
in mac
(add-to-list 'load-path "/opt/homebrew/Cellar/mu/1.10.14/share/emacs/site-lisp/m/mu4e/")
then
(require 'mu4e)

it worked fine. but I don't believe org-msg works.

Mohammed.

@lzmartinico
Copy link
Author

This is a bug with custom functions in the doom module, so of course disabling that will prevent that issue! Downgrading to an earlier version of mu might work, but Doom is now tracking mu 1.12 so the module's code should be upgraded accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet
Projects
Status: No status
Development

No branches or pull requests

2 participants