Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projectile: project-find-file should not follow symlinks #7781

Open
4 tasks done
Atemu opened this issue Mar 30, 2024 · 0 comments
Open
4 tasks done

projectile: project-find-file should not follow symlinks #7781

Atemu opened this issue Mar 30, 2024 · 0 comments
Labels
is:feature Adds or requests new features, or extends existing ones module:core Relevant to Doom core
Milestone

Comments

@Atemu
Copy link

Atemu commented Mar 30, 2024

I confirm that...

  • I have searched the issue tracker, documentation, FAQ, Discourse, and Google, in case this issue has already been reported/resolved.

  • I have read "How to Debug Issues", and will use it to provide as much information about this issue as possible.

  • The issue can be reproduced on the latest available commit of Doom.

  • The issue can be reproduced on a stable release of Emacs, such as 27, 28, or 29. (Unstable versions end in .50, .60, or .9x)

Expected behavior

When I run project-find-file, it should show available symlinks inside the project but not follow them and list content under the followed path.

Current behavior

Symlinks are followed. Hard-coded here:

(concat (format "%s . -0 -H --color=never --type file --type symlink --follow --exclude .git %s"

Removing --follow here fixes the issue but that's not trivially possible from user config.

Steps to reproduce

  1. Have a project with symlinks inside (commonly the case with result symlinks with Nix)
  2. project-find-file
  3. Observe contents under the symlink present

System Information

https://pastebin.com/z6czCYHp

@Atemu Atemu added is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Mar 30, 2024
@hlissner hlissner added is:feature Adds or requests new features, or extends existing ones module:core Relevant to Doom core and removed is:bug Something isn't working as intended needs-triage Issue hasn't been assessed yet labels Mar 30, 2024
@hlissner hlissner added this to the core v3.0 milestone Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:feature Adds or requests new features, or extends existing ones module:core Relevant to Doom core
Projects
Status: In progress
Development

No branches or pull requests

2 participants